fix: SizeValue interface ts error #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I still have the issue with Angular. Could you please merge the fix and create a new release ? |
|
Actually, the fix is not implemented in With Angular, the error is fatal. |
metal3d
added a commit
to metal3d/Croppr.js
that referenced
this pull request
Oct 12, 2022
The pull jamesssooi#58 is not merged and this yields an error using Croppr in Angular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error TS2412: Property '2' of type '"px" | "%" | undefined' is not assignable to numeric index type 'string | number'.