logger added to adapter.py #93
Conversation
requests_mock/adapter.py
Outdated
| @@ -245,6 +249,7 @@ def send(self, request, **kwargs): | |||
| if resp is not None: | |||
| request._matcher = weakref.ref(matcher) | |||
| resp.connection = self | |||
| logger.debug('{} \"{} \" {}'.format(request._request.url,request._request.method, resp.status_code)) | |||
There was a problem hiding this comment.
Where did the format come from? The space after method seems weird. It prints like:
DEBUG:requests_mock.adapter:http://test.com/ "GET " 200
I would think it would either follow apache format, or maybe GET http://test.com 200.
|
Hey thanks for the PR - I love the idea. Question on the format inline as it seems to be referring to something that I'm not aware of. Am happy to merge some version of this, though I wasn't planning another release for a little while. |
|
Hi, ´INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): www.google.de However, I could also change it to the apache format. If you are not planning on releasing for a while could also close the PR, I can create an enhancement request and we are looking for other places where looging might be useful. Afterwards I could implement it and create a new PR. Would that be a good idea? |
|
We can do an enhancement request, but it's probably a bit overkill for a project like this. I'm aware of all the PRs that are lodged (even if it's taking me a bit more time to respond these days). If we can agree on a format then just open PRs wherever you think they are appropriate and we can debate them there. We don't really have all the information required to implement either apache or the urllib3 connection string format (We don't know http version or anything, and we should log the whole path). I just think the I'd prefer the |
|
ok i changed it to the format.. integrating an empty http version doesn't really make sense |
With the requests-mock logger now configured to log the request[1], checking that the logger output does *not* contain the request is invalid. Simplify these two tests by omitting the assertion. [1] jamielennox/requests-mock#93 Closes-bug: #1842978 Change-Id: If3c0447502917bce831d3e9f7ae4c31374dd4380
* Update keystoneauth from branch 'master'
- Simplify session logger object tests
With the requests-mock logger now configured to log the request[1],
checking that the logger output does *not* contain the request is
invalid. Simplify these two tests by omitting the assertion.
[1] jamielennox/requests-mock#93
Closes-bug: #1842978
Change-Id: If3c0447502917bce831d3e9f7ae4c31374dd4380
Now requests-mock records request url in log[1], so it is invalid to check that the logger output does NOT contain request url. Also, fix url passed to request mock as now it requires complete url is passed [1] jamielennox/requests-mock#93 Change-Id: I4bab30a6705b7cab6b5a569dd61c442263e39995
* Update python-keystoneclient from branch 'master'
- Fix unit tests broken by requests-mock
Now requests-mock records request url in log[1], so it is
invalid to check that the logger output does NOT contain
request url.
Also, fix url passed to request mock as now it requires
complete url is passed
[1] jamielennox/requests-mock#93
Change-Id: I4bab30a6705b7cab6b5a569dd61c442263e39995
Version 1.7.0 includes a fix that is breaking some keystoneauth tests: jamielennox/requests-mock#93 Cap at 1.6.0 until we can get keystoneauth refactored to use the new version. Related-Bug: #1842978 Change-Id: I45e2011424c45ce41387164d29f7efd90efdfe63
* Update requirements from branch 'master'
- Merge "Cap requests-mock to 1.6.0"
- Cap requests-mock to 1.6.0
Version 1.7.0 includes a fix that is breaking some keystoneauth tests:
jamielennox/requests-mock#93
Cap at 1.6.0 until we can get keystoneauth refactored to use the new
version.
Related-Bug: #1842978
Change-Id: I45e2011424c45ce41387164d29f7efd90efdfe63
Version 1.7.0 includes a fix that is breaking some keystoneauth tests: jamielennox/requests-mock#93 Cap at 1.6.0 until we can get keystoneauth refactored to use the new version. Change-Id: I45e2011424c45ce41387164d29f7efd90efdfe63
enables the user to use
l=logging.getLogger('requests_mock.adapters')to log all mocked requests and responses, similar to usingl=logging.getLogger('urllib3.connectionpool')