Add log to clone_nightscout.sh #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also updated the comments in the bootstrap file. |
|
One comment about style: If I understand correctly, you always want to add to /xDrip/Logs LGTM. |
tupoybot
pushed a commit
to tupoybot/nightscout-vps
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a log to the "Copy data from another Nightscout" utility.
This is needed because the utility may stop incomplete just due to SSH connectivity. If that happens, the user will have no idea if the process completed or not.
Having the log could be useful. And does not have any drawback.
It may also be useful for the support staff to be able to see that data has been transferred from another Nightscout.