CI: Switch Linux Build to Ubuntu 22.04 runner #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jamulus_headless installed and started properly on:
Found one issue: The compiled-in version lacks the git tag (-v). Therefore, setting this PR to draft again. Logs of the problematic step (qmake): https://github.com/jamulussoftware/jamulus/runs/7931049216?check_suite_focus=true#step:11:77 |
hoffie
force-pushed
the
autobuild-runner-ubuntu22.04
branch
from
4f2c555
to
1e21d6e
Compare
|
Added a workaround. New logs seem to be ok:
Background: I wondered whether we should attempt to make qmake fail loud in such cases, but I guess it might break some user setups (e.g. those who do have a git checkout, but no git binary). |
pljones
approved these changes
Aug 22, 2022
We continue using an Ubuntu 18.04 image via containers. This requires slight adjustments in the Matrix logic and an additional step to install some dependencies (sudo, git) which are usually pre-installed on Github's images. It also causes LD_PRELOAD ERROR messages due to CodeQL. Sadly, there does not seem a way to avoid that. Based on the logs, CodeQL still works properly. The most likely reason for the errors is that CodeQL is installed within the container, but the environment variables for LD_PRELOAD have to be passed via the workflow. As such, the `docker` invocations themselves will try to load the referenced library, which fails as it is only installed within the container. Fixes: jamulussoftware#2786
hoffie
force-pushed
the
autobuild-runner-ubuntu22.04
branch
from
1e21d6e
to
a36fa0b
Compare
ann0see
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR switches the Linux builds to Ubuntu 22.04 runners due to the deprecation of 18.04 runners.
We continue using an Ubuntu 18.04 image via containers. This requires slight adjustments in the Matrix logic and an additional step to install some dependencies (sudo, git) which are usually pre-installed on Github's images.
It also causes LD_PRELOAD ERROR messages due to CodeQL. Sadly, there does not seem a way to avoid that.
Based on the logs, CodeQL still works properly. The most likely reason for the errors is that CodeQL is installed within
the container, but the environment variables for LD_PRELOAD have to be passed via the workflow. As such, the
dockerinvocations themselves will try to load the referenced library, which fails as it is only installed within the container.CHANGELOG: SKIP
(The actual build environment does not even change, it's just the runner)
Context: Fixes an issue?
Fixes: #2786
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Checklist