Display server versions in Connect dialog

[softins]

Short description of changes

Adds a Version column to the server list in the Connect dialog, and populates this once for each server in the list.

CHANGELOG: Client: Display version for each server in the Connect dialog

Context: Fixes an issue?

This is a proof of concept in response to the discussion at https://github.com/orgs/jamulussoftware/discussions/3382#discussioncomment-10941423, although not itself related to access control.

Does this change need documentation? What needs to be documented and how?

On the website, any screenshots of the Connect dialog should be updated.

Status of this Pull Request

Ready for review. We can discuss whether to put it in 3.12.0 (if there is one) or 4.0.0

What is missing until this pull request can be merged?

Only a decision about when. We should also check the column width is ok on all platforms.

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[softins]

Example screen shot:

[softins]

If we add this, I think we should also consider again adding #1940

[ann0see]

I'd like it to be a bit more out of the way (last column) or entirely only showing up on hover (preferred as it's not essential)

[softins]

Well we could rearrange the columns (should probably create some defines or an enum for column numbers, so they can be changed only in one place in the code, matching the .ui), but I don't think hover is a good idea, especially if we want to target tablets and phones too, which don't have hover.

[softins]

Personally, I prefer it where I showed above.

[ann0see]

It's not essential. Ping is more important for example. So it should not be second in my opinion

[softins]

Updated view. At least with an enum for column values it is easier to try different ways.

[ann0see]

The linux standard window size seems to hide the version in the connect dialog. Not really a problem, but just so you know.

[ann0see]

Alternatively we could most likely also calculate this programmatically. It could go out of sync in future due to a mistake?

[softins]

I think a better approach would be to remove the headings from the widget in the .ui file and to set them in the code in the same section as we set the widths. I did consider this, but didn't get around to looking up the correct way to do so. Then the enum would be the one source of truth for column order.

[ann0see]

Tested and despite some small comments, it looks ok.

[softins]

The linux standard window size seems to hide the version in the connect dialog. Not really a problem, but just so you know.

That's interesting, I didn't notice that issue under Linux on my Pi; the connect window was wide enough to show the version column. Is the connect window size remembered in the .ini file?

[ann0see]

Yes. The ini file has the correct size. I deleted the ini file to test the size and that's too small.

[softins]

The linux standard window size seems to hide the version in the connect dialog. Not really a problem, but just so you know.

I've updated the default width in connectdlgbase.ui. Once there is an ini file it will just get overwritten by the saved value.

[mcfnord]

Maybe we could prepare a documentation page that's just a table that lists the advanced features someone might enjoy starting with each particular server version. Presumably this would involve condensing release notes for each version into a single at-a-glance reference.