fix(analysis): Avoid Infinite Error Message Append For Failed Dry-Run…

… Metrics (argoproj#2182) Signed-off-by: Rohit Agrawal <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
jandersen-plaid · Nov 8, 2022 · 1ed8e34 · 1ed8e34
1 parent dcf70df
commit 1ed8e34
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/analysis/analysis.go b/analysis/analysis.go
@@ -510,12 +510,7 @@ func (c *Controller) assessRunStatus(run *v1alpha1.AnalysisRun, metrics []v1alph
 				} else {
 					// Update metric result message
 					if message != "" {
-						failureMessage := fmt.Sprintf("Metric assessed %s due to %s", metricStatus, message)
-						if result.Message != "" {
-							result.Message = fmt.Sprintf("%s: \"Error Message: %s\"", failureMessage, result.Message)
-						} else {
-							result.Message = failureMessage
-						}
+						result.Message = fmt.Sprintf("Metric assessed %s due to %s", metricStatus, message)
 						analysisutil.SetResult(run, *result)
 					}
 					// Update DryRun Summary