Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User message signing and verification #37

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

janezpodhostnik
Copy link
Owner

@janezpodhostnik janezpodhostnik commented Nov 9, 2021

closes: #36

Add user message signing and verification

@janezpodhostnik janezpodhostnik added the enhancement New feature or request label Nov 9, 2021
@janezpodhostnik janezpodhostnik self-assigned this Nov 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #37 (f30c92a) into master (1b8211e) will increase coverage by 0.47%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   80.70%   81.17%   +0.47%     
==========================================
  Files          26       28       +2     
  Lines        1513     1562      +49     
  Branches       92       93       +1     
==========================================
+ Hits         1221     1268      +47     
- Misses        276      277       +1     
- Partials       16       17       +1     
Flag Coverage Δ
unittests 81.17% <91.30%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flow_py_sdk/tx.py 53.95% <33.33%> (-0.84%) ⬇️
flow_py_sdk/signer/signer.py 90.00% <84.61%> (-10.00%) ⬇️
flow_py_sdk/signer/in_memory_verifier.py 90.90% <90.90%> (ø)
flow_py_sdk/__init__.py 100.00% <100.00%> (ø)
flow_py_sdk/signer/__init__.py 100.00% <100.00%> (ø)
flow_py_sdk/signer/in_memory_signer.py 100.00% <100.00%> (ø)
flow_py_sdk/signer/verifier.py 100.00% <100.00%> (ø)
flow_py_sdk/templates.py 55.55% <100.00%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8211e...f30c92a. Read the comment docs.

@janezpodhostnik janezpodhostnik merged commit 8b10f4c into master Nov 22, 2021
@janezpodhostnik janezpodhostnik deleted the janez/user-message-signing-verification branch November 22, 2021 16:12
@janezpodhostnik janezpodhostnik added the minor Minor change label Nov 22, 2021
@oeway
Copy link

oeway commented Nov 23, 2021

Thanks a lot @janezpodhostnik I will give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example for account authentication
3 participants