efactor app directories and enforce ts strict mode #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
louis-jan
commented
Sep 25, 2023
•
louis-jan
commented
- The placement of the Electron app within the "web-client" directory, where it shares a package.json and tsconfig with the web application, is not the intended configuration.
- Refactor Jan Desktop app to typescript.
- Jan web should be able to run outside of electron app (host browsers).
- Yarn workspace.
- Introduce data-plugin as a demo ts plugin.
- Auto Update
- Model management plugin
This comment has been minimized.
This comment has been minimized.
louis-jan
commented
Sep 25, 2023
electron/main.ts
Outdated
|
|
||
| let window; | ||
| const _importDynamic = new Function('modulePath', 'return import(modulePath)') |
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
Analysis Details114 Issues
Coverage and Duplications
Project ID: janhq_jan_AYpD9dALNKTWc87tHFux |
louis-jan
force-pushed
the
chore/refactor-electron-app
branch
from
f73e947
to
444b5d9
Compare
Signed-off-by: James <[email protected]>
Signed-off-by: James <[email protected]>
- remove base-plugin Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]>
store downloaded model to database Signed-off-by: James <[email protected]>
…lish all base plugins
Co-authored-by: Hien To <[email protected]>
hiento09
force-pushed
the
chore/refactor-electron-app
branch
from
6d0ad3a
to
7aba085
Compare
Signed-off-by: James <[email protected]>
* feat: Add function for system monitoring * chore: register plugin functions * chore: move to corresponding directory * chore: bind system monitoring data to UI --------- Co-authored-by: Louis <[email protected]>
Co-authored-by: Hien To <[email protected]>
hiento09
force-pushed
the
chore/refactor-electron-app
branch
from
2aef111
to
64a50e0
Compare
louis-jan
changed the title
hiento09
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.