Allow cleartext communication with mocky.io #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
targetSdkVersionto 28 has introduced a side effect where clear text communication is no longer allowed.When I run the app with a 28 emulator I get an error
<-- HTTP FAILED: java.net.UnknownServiceException: CLEARTEXT communication to www.mocky.io not permitted by network security policyThe easy solution would be to change the
http://www.mocky.io/v2endpoint to https. However their SSL configuration is bad and SSL requests to mocky.io get bounced.They have an issue regarding this here: https://github.com/julien-lafont/Mocky/issues/35
Also it is evident when scanning them with this tool: https://www.sslshopper.com/ssl-checker.html#hostname=https://www.mocky.io/
This PR allows cleartext communication on 28 as described in this SO answer: https://stackoverflow.com/a/50834600/1803821