WithSeed -> WithProposal

agreement/abstractions.go

@@ -54,12 +54,14 @@ type BlockValidator interface {
 // and can now be recorded in the ledger.  This is an optimized version of
 // calling EnsureBlock() on the Ledger.
 type ValidatedBlock interface {
-	// WithSeed creates a copy of this ValidatedBlock with its
-	// cryptographically random seed set to the given value.
+	// WithProposal creates a copy of this ValidatedBlock with its
+	// cryptographically random seed and proposer set. Abstractly, it is how the
+	// agreement code "finishes" a block and makes it a proposal for a specific
+	// account.
 	//
 	// Calls to Seed() or to Digest() on the copy's Block must
 	// reflect the value of the new seed.
-	WithSeed(committee.Seed, basics.Address) ValidatedBlock
+	WithProposal(committee.Seed, basics.Address) ValidatedBlock
 
 	// Block returns the underlying block that has been validated.
 	Block() bookkeeping.Block

agreement/agreementtest/simulate_test.go

@@ -79,7 +79,7 @@ func (b testValidatedBlock) Block() bookkeeping.Block {
 	return b.Inside
 }
 
-func (b testValidatedBlock) WithSeed(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
+func (b testValidatedBlock) WithProposal(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
 	b.Inside.BlockHeader.Seed = s
 	b.Inside.BlockHeader.Proposer = proposer
 	return b

agreement/common_test.go

@@ -165,7 +165,7 @@ func (b testValidatedBlock) Block() bookkeeping.Block {
 	return b.Inside
 }
 
-func (b testValidatedBlock) WithSeed(s committee.Seed, proposer basics.Address) ValidatedBlock {
+func (b testValidatedBlock) WithProposal(s committee.Seed, proposer basics.Address) ValidatedBlock {
 	b.Inside.BlockHeader.Seed = s
 	b.Inside.BlockHeader.Proposer = proposer
 	return b

agreement/fuzzer/ledger_test.go

@@ -93,7 +93,7 @@ func (b testValidatedBlock) Block() bookkeeping.Block {
 	return b.Inside
 }
 
-func (b testValidatedBlock) WithSeed(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
+func (b testValidatedBlock) WithProposal(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
 	b.Inside.BlockHeader.Seed = s
 	b.Inside.BlockHeader.Proposer = proposer
 	return b

agreement/proposal.go

@@ -271,7 +271,7 @@ func proposalForBlock(address basics.Address, vrf *crypto.VRFSecrets, ve Validat
 	if ve.Block().ConsensusProtocol().EnableMining {
 		hdrProp = address
 	}
-	ve = ve.WithSeed(newSeed, hdrProp)
+	ve = ve.WithProposal(newSeed, hdrProp)
 	proposal := makeProposal(ve, seedProof, period, address)
 	value := proposalValue{
 		OriginalPeriod:   period,

data/datatest/impls.go

@@ -65,7 +65,7 @@ func (i entryFactoryImpl) AssembleBlock(round basics.Round) (agreement.Validated
 }
 
 // WithSeed implements the agreement.ValidatedBlock interface.
-func (ve validatedBlock) WithSeed(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
+func (ve validatedBlock) WithProposal(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
 	newblock := *ve.blk
 	newblock.BlockHeader.Seed = s
 	newblock.BlockHeader.Proposer = proposer

ledger/ledgercore/validatedBlock.go

@@ -41,7 +41,7 @@ func (vb ValidatedBlock) Delta() StateDelta {
 }
 
 // WithSeed returns a copy of the ValidatedBlock with a modified seed and associated proposer
-func (vb ValidatedBlock) WithSeed(s committee.Seed, proposer basics.Address) ValidatedBlock {
+func (vb ValidatedBlock) WithProposal(s committee.Seed, proposer basics.Address) ValidatedBlock {
 	newblock := vb.blk
 	newblock.BlockHeader.Seed = s
 	newblock.BlockHeader.Proposer = proposer

ledger/simple_test.go

@@ -154,7 +154,7 @@ func endBlock(t testing.TB, ledger *Ledger, eval *eval.BlockEvaluator, proposer
 
 	// We have this backdoor way to install a proposer or seed into the header
 	// for tests. Doesn't matter that it makes them both the same.
-	*vb = vb.WithSeed(committee.Seed(prp), prp)
+	*vb = vb.WithProposal(committee.Seed(prp), prp)
 
 	err = ledger.AddValidatedBlock(*vb, agreement.Certificate{})
 	require.NoError(t, err)

node/node.go

@@ -1291,8 +1291,8 @@ type validatedBlock struct {
 }
 
 // WithSeed satisfies the agreement.ValidatedBlock interface.
-func (vb validatedBlock) WithSeed(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
-	lvb := vb.vb.WithSeed(s, proposer)
+func (vb validatedBlock) WithProposal(s committee.Seed, proposer basics.Address) agreement.ValidatedBlock {
+	lvb := vb.vb.WithProposal(s, proposer)
 	return validatedBlock{vb: &lvb}
 }