agreement: split ValidatedBlock and AssembledBlock interfaces #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalouf
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
I'm good with this, pending the discussion around AssembledBlock being a subset of ValidatedBlock on algorand#5967 (comment).
|
I caused some conflicts. I think I fixed them, but I'm just going to merge, find out and fix afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as algorand#5967 against algorand#5757. Moves implementation of WithProposal() back to bookkeeping.Block.go — WDYT?