Breaking: rename focusInputOnSelect to closeDropdownOnSelect
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix typo
was: false | "" | "create" | "dupe" | "no-match" now: false | "create" | "dupe" | "no-match"
janosh
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264.
The new
closeDropdownOnSelectis essentially the boolean inverse offocusInputOnSelectbut also controls whether the dropdown is closed on item selection.6534d1d improve readme docs on
'after-input'slot5e03954 improve
'user-msg'slot readme docsdc7662c fix
msgTypetype68cf526 fix
"user-msg"slot demo535a73f close dropdown when
focusInputOnSelect = false2af971e add test 'focusInputOnSelect=%s controls input focus and dropdown closing'
7b2565c update
focusInputOnSelectreadme docs to include dropdown closingaefc03a breaking: rename
focusInputOnSelecttocloseDropdownOnSelect