-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch all exceptions when using pip _internal? #7
Comments
@emilburzo Thanks, I'll definitely look into this, but it might be a little while before I can take any action on it. Since you happened to mention it though... I was unaware (or forgot???) that anyone had gotten awslimitchecker running in Lambda. Is there any chance that you have any code you can share for packaging and/or deployment? |
I think that's fine / there's no rush, affected users can either:
Interesting, I didn't know this was problematic, for me "it just worked" :)
It feels pretty basic, but if it helps someone, sure, I can put a sample repo together. |
@emilburzo Apologies for how long it took me to get around to this. I've confirmed a fix for it in #8 and released that as 1.0.0, which is now live on PyPI. Thank you so much for reporting this! |
@jantman thank you! and also very late, but here's that example awslimitchecker-on-aws-lambda thing |
Bug Report
With the latest version of pip (19.2.3),
versionfinder
(and thusawslimitchecker
) crashes when running on AWS lambda.It is because of a recent addition to
pip
's subversion.py, which doesn't expectsys.stdin
to beNone
I've opened an issue also at pip, but it might make sense to have a broad catch-all exceptions approach for the internal API, in
versionfinder
The text was updated successfully, but these errors were encountered: