Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"preserve" does not require preview any more #133

Merged
merged 2 commits into from
Jul 19, 2024
Merged

"preserve" does not require preview any more #133

merged 2 commits into from
Jul 19, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

Fixes #131.

bswck
bswck approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@bswck bswck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ruff.toml Outdated Show resolved Hide resolved
@DimitriPapadopoulos @bswck
Update URL in ruff.toml comment
ebf8215 
Co-authored-by: Bartosz Sławecki <[email protected]>
@jaraco jaraco merged commit f087fb4 into jaraco:main Jul 19, 2024
12 of 14 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the preview branch July 19, 2024 14:34
@jaraco
Copy link
Owner

jaraco commented Jul 19, 2024

Oh, shoot. As I'm applying this change to all the projects, I'm noticing it's a very sensitive setting. Setuptools, for example, enables this same setting "to get hugged parenthesis unwrapping". I think what that means as that by applying this change, all the projects are going to lose hugged parenthesis unwrapping. I think that's why I was surprised when I saw this diff after applying this latest skeleton. So much foot gun in just one setting.

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Jul 19, 2024 •
edited
Loading

Indeed, preview is a handle for a set of assorted "beta" rules. It's usually not a concern when applied to a single project, but when applied to the skeleton of many projects, I can now see the potential damage caused by the lack of granularity.

Perhaps it was a bad idea to enable preview and its associated "beta" rules in the first place. Experimental behaviour has no place in the dependency of a myriad of projects. But I can see it might be too late to revert.

@jaraco
Copy link
Owner

jaraco commented Jul 19, 2024

Perhaps it was a bad idea to enable preview and its associated "beta" rules in the first place. Experimental behaviour has no place in the dependency of a myriad of projects. But I can see it might be too late to revert.

Unfortunately, the desired behavior (preserve quotes) was only available behind that setting.

Given that all the projects are currently tuned to preview=true, I'm inclined to keep it, to avoid the flux of unhugging the parenthesis and later re-introducing them. I'd rather be on the cutting edge of behavior than to lose these benefits.

@jaraco jaraco mentioned this pull request Jul 19, 2024
Open
jaraco added a commit that referenced this pull request Jul 19, 2024
@jaraco
Re-enable preview, this time not for one specific feature, but for al…
ab34814 
…l features in preview.

Ref #133
clrpackages pushed a commit to clearlinux-pkgs/pypi-setuptools that referenced this pull request Jul 23, 2024
@fenrus75
pypi-setuptools: Autospec creation for update from version 71.0.3 to …
e99c549 
…version 71.1.0

Avasam (3):
      Enforce return types for typed public functions
      Update mypy to 1.11
      Update pyproject.toml

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (9):
      Rely on pytest defaults for reporting.
      Revert "Pin Sphinx to <7.4 as workaround for sphinx-doc/sphinx#12613. Closes #4474."
      Revert "Fix error when integrating with pip (#3823)"
      👹 Feed the hobgoblins (delint).
      Removed lingering unused code around Distribution._patched_dist.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Bump version: 71.0.3 → 71.0.4
      Switch to uv for vendoring.
      Bump version: 71.0.4 → 71.1.0

Michał Górny (1):
      Add Python version specifiers to [core] dependencies
clrpackages pushed a commit to clearlinux-pkgs/pypi-importlib_metadata that referenced this pull request Jul 25, 2024
@fenrus75
pypi-importlib_metadata: Autospec creation for update from version 8.…
d67a6c9 
…0.0 to version 8.1.0

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (5):
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Add test capturing failed expectation. Ref #489.
      Prioritize valid dists to invalid dists when retrieving by name.
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-tempora that referenced this pull request Jul 30, 2024
@fenrus75
pypi-tempora: Autospec creation for update from version 5.6.0 to vers…
0611f7a 
…ion 5.7.0

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (5):
      Prefer "Source" to "Homepage" for the repository label.
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Add a tzinfos mapping and parse method for easy datetime parsing with timezone support.
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-jaraco.text that referenced this pull request Jul 30, 2024
@fenrus75
pypi-jaraco.text: Autospec creation for update from version 3.14.0 to…
a4a4b34 
… version 4.0.0

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (3):
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Made 'inflect' an optional dependency. The show-newlines script now will crash unless jaraco.text[inflect] is installed.
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-jaraco.functools that referenced this pull request Aug 8, 2024
@fenrus75
pypi-jaraco.functools: Autospec creation for update from version 4.0.…
93f7d17 
…1 to version 4.0.2

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (10):
      Remove pins for resolved issues.
      Allow macos on Python 3.8 to fail as GitHub CI has dropped support.
      Move project.urls to appear in the order that ini2toml generates it. Remove project.scripts.
      Revert "Allow macos on Python 3.8 to fail as GitHub CI has dropped support."
      Rename extras to align with core metadata spec.
      Prefer "Source" to "Homepage" for the repository label.
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Expand docstring with link to wikipedia.
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-keyring that referenced this pull request Aug 8, 2024
@fenrus75
pypi-keyring: Autospec creation for update from version 25.2.1 to ver…
5762b2c 
…sion 25.3.0

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (12):
      Add a test capturing the missed expectation. Ref #668.
      Mark the test as xfail where it's failing (Windows).
      Rename extras to align with core metadata spec.
      Prefer "Source" to "Homepage" for the repository label.
      Add a test to cover core.disable. Reveals EncodingWarning. Ref #685
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Deprecate setting a password for an empty username.
      Extract method for registration.
      When constructing KeyringBackend subclasses, wrap set_password to enforce non-empty usernames.
      Add news fragment.
      Finalize

RatishT (1):
      Fix pylint warning `unspecified-encoding`
clrpackages pushed a commit to clearlinux-pkgs/pypi-zipp that referenced this pull request Aug 13, 2024
@fenrus75
pypi-zipp: Autospec creation for update from version 3.19.2 to versio…
78948b0 
…n 3.20.0

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (9):
      Prefer "Source" to "Homepage" for the repository label.
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Add failing test capturing missed expectation.
      Also match directories in Path.glob.
      Narrow the versions under which Traversable is imported from importlib.abc. Fixes DeprecationWarning.
      Finalize
      Made the zipfile compatibility overlay available as zipp.compat.overlay.
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-configparser that referenced this pull request Aug 20, 2024
@fenrus75
pypi-configparser: Autospec creation for update from version 7.0.0 to…
839c5ea 
… version 7.1.0

Bartosz Sławecki (1):
      Move project metadata to `pyproject.toml` (jaraco/skeleton#122)

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (19):
      Pin against pytest 8.1.x due to pytest-dev/pytest#12194.
      Migrated config to pyproject.toml using jaraco.develop.migrate-config and ini2toml.
      Allow macos on Python 3.8 to fail as GitHub CI has dropped support.
      Move project.urls to appear in the order that ini2toml generates it. Remove project.scripts.
      Revert "Allow macos on Python 3.8 to fail as GitHub CI has dropped support."
      Rename extras to align with core metadata spec.
      Prefer "Source" to "Homepage" for the repository label.
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Use /usr/bin/env to launch py from the path.
      cpython-v3.13.0rc1 rev=e4a3e786a5eb
      👹 Feed the hobgoblins (delint).
      Reformatted using ruff
      Converted sync script to use typer instead of autocommand.
      Add news fragment.
      Finalize
      Allow to specify any ref to sync.
      cpython-main rev=be257c58152e
      Finalize
clrpackages pushed a commit to clearlinux-pkgs/pypi-jaraco.context that referenced this pull request Aug 22, 2024
@fenrus75
pypi-jaraco.context: Autospec creation for update from version 5.3.0 …
cf4a9da 
…to version 6.0.0

Bartosz Sławecki (2):
      Add link to blog entry from jaraco/skeleton#115 above CI build matrix.
      Move project metadata to `pyproject.toml` (jaraco/skeleton#122)

Dimitri Papadopoulos Orfanos (2):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)

Jason R. Coombs (24):
      Pin against pytest 8.1.x due to pytest-dev/pytest#12194.
      Migrated config to pyproject.toml using jaraco.develop.migrate-config and ini2toml.
      Allow macos on Python 3.8 to fail as GitHub CI has dropped support.
      Move project.urls to appear in the order that ini2toml generates it. Remove project.scripts.
      Revert "Allow macos on Python 3.8 to fail as GitHub CI has dropped support."
      Rename extras to align with core metadata spec.
      Prefer "Source" to "Homepage" for the repository label.
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Replace stale comment with a docstring explaining the behavior.
      Expand the docstring for on_interrupt to explain where it might be useful.
      Removed deprecated 'tarball_context', 'infer_compression', and 'null' contexts.
      Moved module into its own package.
      Replace if block with algebraic expression.
      Replace explicit devnull with subprocess.devnull.
      Added test coverage for repo_context.
      Fixed bug in repo_context where standard output from git would not be hidden (because git emits standard output on the stderr stream).
      Suppress logging from the tarfile_served.
      Expanded test coverage to cover 100% of the code.
      Declare project as typed.
      Finalize
      Apply Gemini's ideas for improving the types.
      Add workaround for cleaning out read-only files when wiping repo context.
      🚡 Toil the docs.
clrpackages pushed a commit to clearlinux-pkgs/pypi-jaraco.collections that referenced this pull request Aug 30, 2024
@fenrus75
pypi-jaraco.collections: Autospec creation for update from version 5.…
faf0456 
…0.1 to version 5.1.0

Anderson Bravalheri (1):
      Add `--fix`  flag to ruff pre-commit hook for automatic suggestion of fixes (jaraco/skeleton#140)

Avasam (4):
      Add Protocols, remove @overload, from `.coveragerc` `exclude_also` (jaraco/skeleton#135)
      Loosen restrictions on mypy (jaraco/skeleton#136)
      Pass mypy and link issues
      Fully typed `RangeMap` and avoid complete iterations to find matches (#16)

Bartosz Sławecki (1):
      Move project metadata to `pyproject.toml` (jaraco/skeleton#122)

Dimitri Papadopoulos Orfanos (3):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)
      Update to the latest ruff version (jaraco/skeleton#137)

Jason R. Coombs (14):
      Pin against pytest 8.1.x due to pytest-dev/pytest#12194.
      Migrated config to pyproject.toml using jaraco.develop.migrate-config and ini2toml.
      Allow macos on Python 3.8 to fail as GitHub CI has dropped support.
      Move project.urls to appear in the order that ini2toml generates it. Remove project.scripts.
      Revert "Allow macos on Python 3.8 to fail as GitHub CI has dropped support."
      Rename extras to align with core metadata spec.
      Prefer "Source" to "Homepage" for the repository label.
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Split the test dependencies into four classes (test, cover, type, check). (jaraco/skeleton#139)
      Add upstream and local sections for 'type' extra, since many projects will have 'types-*' dependencies.
      Disable mypy for now. Ref jaraco/skeleton#143
      Finalize
      Remove unsupported attribution. See jaraco/skeleton#144.
clrpackages pushed a commit to clearlinux-pkgs/pypi-inflect that referenced this pull request Sep 10, 2024
@fenrus75
pypi-inflect: Autospec creation for update from version 7.3.1 to vers…
269d4be 
…ion 7.4.0

Anderson Bravalheri (1):
      Add `--fix`  flag to ruff pre-commit hook for automatic suggestion of fixes (jaraco/skeleton#140)

Avasam (2):
      Add Protocols, remove @overload, from `.coveragerc` `exclude_also` (jaraco/skeleton#135)
      Loosen restrictions on mypy (jaraco/skeleton#136)

Dimitri Papadopoulos Orfanos (3):
      "preserve" does not require preview any more (jaraco/skeleton#133)
      Enforce ruff/Perflint rule PERF401 (jaraco/skeleton#132)
      Update to the latest ruff version (jaraco/skeleton#137)

Jason R. Coombs (14):
      Exclude pytest-ruff (and thus ruff), which cannot build on cygwin.
      Re-enable preview, this time not for one specific feature, but for all features in preview.
      Split the test dependencies into four classes (test, cover, type, check). (jaraco/skeleton#139)
      Add upstream and local sections for 'type' extra, since many projects will have 'types-*' dependencies.
      🧎‍♀️ Genuflect to the types.
      Move comment
      Construct the _gend_sing dictionary statically.
      Disable mypy for now. Ref jaraco/skeleton#143
      Move overload-overlap disablement to its own line for easier diffs and simpler relevant comments.
      Add a degenerate nitpick_ignore for downstream consumers. Add a 'local' comment to delineate where the skeleton ends and the downstream begins.
      Add support for linking usernames.
      Include the trailing slash in disable_error_code(overload-overlap), also required for clean diffs.
      Add news fragment.
      Finalize

Josh Stephenson (1):
      Clarify that inflect is for English.

Mitchel Humpherys (2):
      Handle a single apostrophe more gracefully
      Add a test for a single-character apostrophe string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bswck bswck bswck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No need for preview = true in ruff.toml any more
3 participants
@DimitriPapadopoulos @jaraco @bswck