Implement is_symlink.

Closes #117
jaraco · May 26, 2024 · dc5fe8f · dc5fe8f
1 parent 387dcea
commit dc5fe8f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/newsfragments/117.feature.rst b/newsfragments/117.feature.rst
@@ -0,0 +1 @@
+Implement is_symlink.
diff --git a/tests/test_path.py b/tests/test_path.py
@@ -515,7 +515,6 @@ def test_eq_hash(self, alpharep):
         root = zipfile.Path(alpharep)
         assert root in {root}
 
-    @__import__('pytest').mark.xfail(reason="Not implemented")
     @pass_alpharep
     def test_is_symlink(self, alpharep):
         root = zipfile.Path(alpharep)

diff --git a/zipp/__init__.py b/zipp/__init__.py
@@ -5,6 +5,7 @@
 import contextlib
 import pathlib
 import re
+import stat
 import sys
 
 from .compat.py310 import text_encoding
@@ -391,9 +392,11 @@ def match(self, path_pattern):
 
     def is_symlink(self):
         """
-        Return whether this path is a symlink. Always false (python/cpython#82102).
+        Return whether this path is a symlink.
         """
-        return False
+        info = self.root.getinfo(self.at)
+        mode = info.external_attr >> 16
+        return stat.S_ISLNK(mode)
 
     def glob(self, pattern):
         if not pattern: