Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration required before Sept. 1 - 2014 #45

Merged
merged 1 commit into from
Mar 5, 2015

Conversation

jfromaniello
Copy link
Contributor

This pull request include some changes needed before September 1 - 2014 as explained here:

https://developers.google.com/+/api/auth-migration#timetable

Please also notice that I've added the default scope to profile so we don't break existing examples and documentation.

I've also added some warns that might be useful for some folks using this library.

Thanks

@codeactual
Copy link

Thanks for kicking this off. I think there might be two more changes to make:

  1. I think Strategy.prototype.userProfile in lib/passport-google-oauth/oauth2.js needs one more change: "profile.emails = json.emails;".
  2. Try replacing 0.4 with 0.10 in .travis.yml to fix the current build error.

@jfromaniello
Copy link
Contributor Author

Also we should make clear that now you have to enable Google+ API in the api console otherwise it works the first time but not on subsequent calls

@jaredhanson
Copy link
Owner

Merged with changes described in #66. Thanks!

@jfromaniello
Copy link
Contributor Author

Thanks to you man, :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants