Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formik v3 Umbrella PR. #3231

Open
wants to merge 94 commits into
base: main
Choose a base branch
from
Open

Formik v3 Umbrella PR. #3231

wants to merge 94 commits into from

Commits on Mar 8, 2021

  1. Started to reimplement subscriber. 

    Added Ref State.
Added useSelectorComparer.
Starting to build subscriptions.
    @johnrom
    johnrom committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    9f8765e View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Grab types from other PR, to simplify later.

    @johnrom
    johnrom committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    4dc160b View commit details
    Browse the repository at this point in the history

  2. Grab types from other PR, to simplify later.

    @johnrom
    johnrom committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    ef66e38 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'johnrom/subscriber' of github.com:johnrom/formik into j… 

    …ohnrom/subscriber
    @johnrom
    johnrom committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    b77d371 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Set up dev environment and implement Field. 

    use-subscriptions might not work in React 17? Seems returning the previous value doesn't bail out the render.
    @johnrom
    johnrom committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    3e6e20c View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Memoize Formik API and make it rain optimized states. 

    Sync up formik-native and formik for v3.
    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    881d7e6 View commit details
    Browse the repository at this point in the history

  2. Roll back unnecessary tsconfig change.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    b8e7fcd View commit details
    Browse the repository at this point in the history

  3. Fix Sign In App Page.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    feaee0e View commit details
    Browse the repository at this point in the history

  4. Roll back unnecessary tsconfig change.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a5a2f47 View commit details
    Browse the repository at this point in the history

  5. Wire up FormikConsumer.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    4037473 View commit details
    Browse the repository at this point in the history

  6. Remove implementation details from deprecated comments.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e2c496c View commit details
    Browse the repository at this point in the history

  7. Don't expose internal useOptimizedSelector.

    @johnrom
    johnrom committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a78459b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Reduce maintenance surface by moving useOptimizedSelector into its ow… 

    …n package.
    @johnrom
    johnrom committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    747ce07 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Update use-optimized-selector

    @johnrom
    johnrom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    9d10f82 View commit details
    Browse the repository at this point in the history

  2. Move useFormikComputedState to api.useComputedState, useIsDirty and u… 

    …seIsValid
    @johnrom
    johnrom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    0d1cbfd View commit details
    Browse the repository at this point in the history

  3. Accidental import change.

    @johnrom
    johnrom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    0c18ebb View commit details
    Browse the repository at this point in the history

  4. Remove TSConfig path aliases during build.

    @johnrom
    johnrom committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    3ab46cd View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. If we're calling our own reducer, we don't need to useReducer! setSta… 

    …te will do. If we call our own reducer then use useReducer dispatch, `state.values !== getState().values`.
    @johnrom
    johnrom committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5011168 View commit details
    Browse the repository at this point in the history

  2. Optimize field meta and computed state with shallow equals.

    @johnrom
    johnrom committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    a5f4643 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Move Computed State into normal state helpers so that FormikState = F… 

    …ormikReducerState + FormikComputedState.

Add Fixtures and Tutorial code to /app.
    @jawnrom
    jawnrom committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    c9b9579 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3 from jawnstreams/johnrom/downstream 

    Consolidate State and Add Tutorial + Fixtures.
    @johnrom
    johnrom authored Mar 22, 2021
    Configuration menu
    Copy the full SHA
    611432a View commit details
    Browse the repository at this point in the history

  3. Clarify RenderState vs GetState. Fix Test.

    @johnrom
    johnrom committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    dc2e2fa View commit details
    Browse the repository at this point in the history

  4. Fix tests with updated /app structure.

    @johnrom
    johnrom committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    0764e12 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Remove unused helper components from app/

    @johnrom
    johnrom committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0079948 View commit details
    Browse the repository at this point in the history

  2. Ignore TypeScript Build Errors during app/ build.

    @johnrom
    johnrom committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    9c4cd01 View commit details
    Browse the repository at this point in the history

  3. Add Changeset

    @johnrom
    johnrom authored Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ba1fdb9 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Add Parse / Format to Subscriptions PR

    @johnrom
    johnrom committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    e800bf8 View commit details
    Browse the repository at this point in the history

  2. Add changes from FieldArray over reducer-refs PR. 

    For some reason, the tests for remove only worked when they were async or render was moved from beforeEach to the individual tests.
    @johnrom
    johnrom committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    c06dff8 View commit details
    Browse the repository at this point in the history

  3. Add Field Array to App Index

    @johnrom
    johnrom committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    ba6f6c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Fix UseField type definition, add micro-hooks.

    @johnrom
    johnrom committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    70de3d1 View commit details
    Browse the repository at this point in the history

  2. Separate FormikContext and FormikConfigContext

    @johnrom
    johnrom committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    a8e5cbf View commit details
    Browse the repository at this point in the history

  3. Add FormikConfig to connect, some type fixes.

    @johnrom
    johnrom committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    d718684 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Merge branch 'johnrom/subscriber' into johnrom/use-optimized-selector 

    # Conflicts:
#	packages/formik/src/hooks/useFormikState.ts
    @johnrom
    johnrom committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    df779d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Isolate subscriptions logic from useFormik to enforce correct use of … 

    …API.

Moved FieldHelpers to their own hooks.
Removed batchedUpdates since we use an Effect.
Some minor type fixes, code and documentation cleanup.
    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    dfde363 View commit details
    Browse the repository at this point in the history

  2. Fix useFormikState documentation, fix getState stability.

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    46a6e17 View commit details
    Browse the repository at this point in the history

  3. Get rid of unnecessary, autocompleted import.

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ee43bb2 View commit details
    Browse the repository at this point in the history

  4. React.SFC -> FC

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    7949c3d View commit details
    Browse the repository at this point in the history

  5. Null coalesced errors and touched during resetForm.

    @johnrom
    johnrom committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    94b8f22 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Merge branch 'johnrom/subscriber' into johnrom/parse-format-subscript… 

    …ions

# Conflicts:
#	packages/formik/src/Formik.tsx
    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    2e75c75 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'johnrom/subscriber' into johnrom/field-array-subscriptions 

    # Conflicts:
#	packages/formik/src/Formik.tsx
#	packages/formik/src/hooks/useEventCallback.ts
    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    6355689 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'johnrom/parse-format-subscriptions' into johnrom/micro-… 

    …hooks-and-field-fixes

# Conflicts:
#	packages/formik/src/Field.tsx
#	packages/formik/src/hooks/hooks.ts
#	packages/formik/src/utils.ts
    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    2327d3b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'johnrom/subscriber' into johnrom/use-optimized-selector 

    # Conflicts:
#	packages/formik/src/Formik.tsx
    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    39f7cfd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'johnrom/subscriber' into johnrom/use-formik-config 

    # Conflicts:
#	packages/formik/src/Formik.tsx
#	packages/formik/src/types.tsx
    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    06b4bbb View commit details
    Browse the repository at this point in the history

  6. Tiny Field Fixes

    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    00dac43 View commit details
    Browse the repository at this point in the history

  7. Update App/ to reflect config changes.

    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    f49f9e2 View commit details
    Browse the repository at this point in the history

  8. Fixed other instance of useFormik.

    @johnrom
    johnrom committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    86eafd6 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Move render optimization to FormikProvider.

    @johnrom
    johnrom committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    1821200 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'johnrom/field-array-subscriptions' into johnrom/v3 

    # Conflicts:
#	app/pages/index.tsx
    @johnrom
    johnrom committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    ea22bab View commit details
    Browse the repository at this point in the history

  3. Merge branch 'johnrom/use-optimized-selector' into johnrom/v3

    @johnrom
    johnrom committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    1060bfd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'johnrom/micro-hooks-and-field-fixes' into johnrom/v3

    @johnrom
    johnrom committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    48c5771 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'johnrom/use-formik-config' into johnrom/v3 

    # Conflicts:
#	packages/formik/src/Formik.tsx
    @johnrom
    johnrom committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    c4e7a41 View commit details
    Browse the repository at this point in the history

  6. Test packages.

    @johnrom
    johnrom committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    6d08add View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. fixed SetValues type, adding functional variant

    @johnrom
    johnrom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    f3bd303 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'johnrom/subscriber' into johnrom/v3

    @johnrom
    johnrom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a9216a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Set package.json versions back to their originals, so changeset can u… 

    …pdate it instead.
    @johnrom
    johnrom committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    4821467 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into johnrom/v3 

    # Conflicts:
#	packages/formik/src/Formik.tsx
#	packages/formik/src/types.tsx
    @johnrom
    johnrom committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    e0b804f View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Merge remote-tracking branch 'upstream/master' into johnrom/v3-remerged 

    # Conflicts:
#	packages/formik/src/Formik.tsx
#	packages/formik/src/types.tsx
    @johnrom
    johnrom committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    788c258 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'johnrom/v3-remerged' into johnrom/v3

    @johnrom
    johnrom committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    75c3c4d View commit details
    Browse the repository at this point in the history

  3. Re-merge these files because apparently they failed last time.

    @johnrom
    johnrom committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f24e151 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Do basic radio / checkbox parsing, and put all the value parse logic … 

    …in one place between field.onChange and Formik.
    @johnrom
    johnrom committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    51502dc View commit details
    Browse the repository at this point in the history

  2. Merge pull request #7 from johnrom/johnrom/parsing-refactor 

    Parsing Refactor
    @johnrom
    johnrom authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    58b538f View commit details
    Browse the repository at this point in the history

  3. Add publish package.json

    @johnrom
    johnrom committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    cb07eaa View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Batch updates instead of relying on state + effect.

    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    4364adb View commit details
    Browse the repository at this point in the history

  2. Correct attribution, document alternate-renderers and allow devs to o… 

    …verride batching.
    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    ec88672 View commit details
    Browse the repository at this point in the history

  3. Fix batch to reuse computed state. Add some comments to help explain … 

    …logic.
    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    879fc05 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'johnrom/v3' into johnrom/v3-publish

    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    baab2b8 View commit details
    Browse the repository at this point in the history

  5. Publish refs4

    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    27aeccb View commit details
    Browse the repository at this point in the history

  6. RN is not detecting .native suffix.

    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    4b76e2b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'johnrom/v3' into johnrom/v3-publish

    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    0620d41 View commit details
    Browse the repository at this point in the history

  8. Change to use entrypoints instead of magic es modules.

    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    a173534 View commit details
    Browse the repository at this point in the history

  9. Manually built native files and removed prepublish action.

    @johnrom
    johnrom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    41a8c4a View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Testing out manual native build

    @johnrom
    johnrom committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    42f7a0e View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Merge branch 'master' into johnrom/v3-publish

    @johnrom
    johnrom committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    fa352ee View commit details
    Browse the repository at this point in the history

  2. Fix circular reference

    @johnrom
    johnrom committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    56cdc92 View commit details
    Browse the repository at this point in the history

  3. Manually build a native version with tsdx, move it to index.native.js… 

    …, then build a web version.
    @johnrom
    johnrom committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    5934815 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Merge branch 'master' into johnrom/v3

    @jaredpalmer
    jaredpalmer authored Aug 26, 2021
    Configuration menu
    Copy the full SHA
    db6f834 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Add full native app for testing using expo.

    @johnrom
    johnrom committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    d5212de View commit details
    Browse the repository at this point in the history

  2. Configure expo for yarn workspaces.

    @johnrom
    johnrom committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3e9dbb1 View commit details
    Browse the repository at this point in the history

  3. Specific react and react-dom versions to fix workspace deduplication.

    @johnrom
    johnrom committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    ff266b5 View commit details
    Browse the repository at this point in the history

  4. Native batch is working on Android, but not React-Native Web (Web is … 

    …using React-Dom, pulled from the monorepo).
    @johnrom
    johnrom committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b4b889f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. Fix handleChange type issue, remove package.json field for formik-nat… 

    …ive.
    @johnrom
    johnrom committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    a133f2e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/johnrom/v3' into johnrom/native-… 

    …tests

# Conflicts:
#	packages/formik/src/index.alternate.tsx
#	packages/formik/src/index.native.tsx
#	packages/formik/src/index.tsx
    @johnrom
    johnrom committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    d8e2923 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #8 from johnrom/johnrom/native-tests 

    Native App Tests
    @johnrom
    johnrom authored Sep 12, 2021
    Configuration menu
    Copy the full SHA
    4a7b3b5 View commit details
    Browse the repository at this point in the history

  4. Fix circular dependencies.

    @johnrom
    johnrom committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    bbd0eaf View commit details
    Browse the repository at this point in the history

  5. Switch from npm to yarn scripts.

    @johnrom
    johnrom committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    2e8079c View commit details
    Browse the repository at this point in the history

  6. Bump custom tsdx version to fix line endings.

    @johnrom
    johnrom committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    4548b41 View commit details
    Browse the repository at this point in the history

  7. Updated yarn.lock.

    @johnrom
    johnrom committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    66ca554 View commit details
    Browse the repository at this point in the history

  8. noclean3 for LF once and for all.

    @johnrom
    johnrom committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    1ad47cd View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Provide a default selector because it can be frustrating not to have … 

    …it. It's not ideal for it to be used, though...
    @johnrom
    johnrom committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    60801e7 View commit details
    Browse the repository at this point in the history

  2. Add optional selector to useFormikSubscription.

    @johnrom
    johnrom committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    c43ffc0 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. add default Return type to formik.useState.

    @johnrom
    johnrom committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3ba242a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Add missing useIsValidating hook

    @dantman
    dantman committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    45e28c6 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Merge pull request #9 from dantman/johnrom-v3-isvalidating 

    Add missing useIsValidating hook
    @johnrom
    johnrom authored Oct 28, 2021
    Configuration menu
    Copy the full SHA
    a38ded4 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Remove field from form-level validations. This isn't how it should be… 

    … handled anyway. We'd want to dispatch a request to validate specific fields which can be cancelled as more validations are requested.
    @johnrom
    johnrom committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    f899b89 View commit details
    Browse the repository at this point in the history