Skip to content

Commit

Permalink
(clean): remove redundant tsconfig strict opts in tests (#690)
Browse files Browse the repository at this point in the history
- removed them in the templates in a previous commit, forgot to remove
  them in the tests too
  - presets would really help with this duplication / inconsistency
    problem

- noImplicitAny, noImplicitThis, alwaysStrict, strictNullChecks,
  strictFunctionTypes, and strictPropertyInitialization are already
  enabled by strict, no need to configure them twice
  • Loading branch information
agilgur5 authored Apr 20, 2020
1 parent 3c65bdf commit 5c73483
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 36 deletions.
6 changes: 0 additions & 6 deletions test/e2e/fixtures/build-default/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down
6 changes: 0 additions & 6 deletions test/e2e/fixtures/build-invalid/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down
6 changes: 0 additions & 6 deletions test/e2e/fixtures/build-withTsconfig/tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down
6 changes: 0 additions & 6 deletions test/integration/fixtures/build-options/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down
6 changes: 0 additions & 6 deletions test/integration/fixtures/build-withBabel/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down
6 changes: 0 additions & 6 deletions test/integration/fixtures/build-withConfig/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
"sourceMap": true,
"rootDir": "./src",
"strict": true,
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
Expand Down

0 comments on commit 5c73483

Please sign in to comment.