Pr/44 merge conflicts resolved #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sindre Sorhus <[email protected]> Fixes sindresorhus#20
sindresorhus#40 eliminated the arguments passed to the click events in both the save image and inspect element context menu items. However the PR description had only referenced issues with the click event in inspect element. As a result of this change [some apps have lost the save image functionality when passing their browser window](mattermost/desktop#707). The cause of this failure is the fact that [electron-dl](https://github.com/sindresorhus/electron-dl/blob/master/index.js#L129) requires methods exposed by the `win` provided by the click event.
Fixes sindresorhus#59 Closes sindresorhus#61
|
@JoniVR Thanks for the PR! I'll merge it and see if I can fix the remaining issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
So here's the PR, you'll probably still need to fix some stuff as this was a work in progress.
If you'd rather start fresh on your own than just ignore this ;)
Some things that still need to be fixed (I think):
fixture.jsfixture.jsedit:
I accidentally closed the first one