Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ffmpeg improvements #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ffmpeg improvements #27

wants to merge 1 commit into from

Conversation

tombh
Copy link

@tombh tombh commented Apr 24, 2016

I've been playing with using hipitext to output video streams. First I needed to change some symbols to compile against newer versions of ffmpeg, namely v3.0.1. Then I also needed to add some crude substr detection for URIs rather than just file extensions.

BTW, hiptext is waaaaaaaaay better than mplayer's libcaca etc.

The compiler still throws some warnings about deprecated symbols. Can/should the Makefile pin to a specific version of ffmpeg?

Oh yes! Almost forgot. I first came across hiptext through rickrollrc! Happy days 😊

@jart
Copy link
Owner

jart commented May 25, 2016

Sorry I didn't notice this until now! Don't be shy to ping me at [email protected] if I ever fall behind. I'll review this as soon as possible. Promise :)

@tombh
Copy link
Author

tombh commented May 27, 2016

No rush, but thanks :)

@xiamaz
Copy link

xiamaz commented Jun 21, 2016

Needed this pull request to build against ffmpeg on latest arch build.

CHECK(frame_ = avcodec_alloc_frame());
CHECK(frame_rgb_ = avcodec_alloc_frame());
int rgb_bytes = avpicture_get_size(PIX_FMT_RGB24, width_, height_);
CHECK(frame_ = av_frame_alloc());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't compile on my system.

You probably want to put something like this at the top of the file.

#if LIBAVUTIL_VERSION_INT <= AV_VERSION_INT(52, 9, 0)
#define av_frame_alloc avcodec_alloc_frame
#endif

@jart
Copy link
Owner

jart commented Jun 21, 2016

Ok I took a look finally. If we can maintain backwards compatibility with what I have installed on my system (Ubuntu 14.04) then I'm happy.

@jart
Copy link
Owner

jart commented Jun 23, 2016

I'm so sorry, but when you get around to updating PR, you'll get a conflict rebasing this on master. I just migrated the project to GNU autotools. (That included moving movie.cc -> src/movie.cc.) This might actually help you deal with the breaking change in ffmpeg in a more proper manner. Maybe someone defined m4 macros for dealing with this.

Compile against newer versions of ffmpeg, namely v3.0.1
Fixes jart#36
@tombh
Copy link
Author

tombh commented Aug 18, 2016

Is this update ok? I couldn't find an m4 macro, but it wasn't hard
just doing it with C macros. There's still 2 deprecations warnings,
but they are for functions that also need new args as well as
renaming. But like I say they're just warnings for the moment.

On 23/06/2016, Justine Tunney [email protected] wrote:

I'm so sorry, but when you get around to updating PR, you'll get a conflict
rebasing this on master. I just migrated the project to GNU autotools. (That
included moving movie.cc -> src/movie.cc.) This might actually help you deal
with the breaking change in ffmpeg in a more proper manner. Maybe someone
defined m4 macros for dealing with this.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#27 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants