Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite using karma #3505

Merged
merged 1 commit into from
Feb 20, 2015
Merged

Run test suite using karma #3505

merged 1 commit into from
Feb 20, 2015

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Feb 19, 2015

Me and @akre54 were discussing this yesterday on this commit megawac@bea414e

This commit makes travis test using Phantom, Chrome and FF. Later we can do sauce as well

A later commit can omit phantomjs from the dev dependencies (which would be sweet!) and assume the user has firefox installed. This assumption would allow people to omit the 13MB buggy install every time and if they dont have ff they can use chrome or opera or whatever else they want no probs.

We did this a couple days ago on underscore as well jashkenas/underscore#2054

@akre54
Copy link
Collaborator

akre54 commented Feb 19, 2015

Chrome failed on Travis. Any ideas of how to handle this?

Also I removed the test-amd.html file since it's pretty much superfluous. If you pull in master you should be up to date.

@megawac
Copy link
Collaborator Author

megawac commented Feb 19, 2015

@akre54 just karma-runner/karma#1144 had to run in sandbox apparently

@braddunbar
Copy link
Collaborator

I'm all for using a real browser for testing instead of phantom. 👍

We still need to swap out the npm test script and add karma-cli to package.json right?

@Florian-R
Copy link

We still need to swap out the npm test script and add karma-cli to package.json right?

No need to add karma-cli as a dependencie,

"scripts": {
   "test": "./node_modules/karma/bin/karma start --single-run"
}

in the package.json does the trick.

@akre54
Copy link
Collaborator

akre54 commented Feb 20, 2015

Awesome. Let's get to fixing #3434 now.

akre54 added a commit that referenced this pull request Feb 20, 2015
Run test suite using karma
@akre54 akre54 merged commit 8dc6be9 into jashkenas:master Feb 20, 2015
@megawac megawac deleted the karma branch February 20, 2015 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants