disallow inline chained call after func glyph (#4590)

jashkenas · Jun 30, 2017 · 58c6086 · 58c6086
1 parent b1d2061
commit 58c6086
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/lib/coffeescript/rewriter.js b/lib/coffeescript/rewriter.js
diff --git a/src/rewriter.coffee b/src/rewriter.coffee
@@ -434,7 +434,7 @@ exports.Rewriter = class Rewriter
         for j in [1..2] when @tag(i + j) in ['OUTDENT', 'TERMINATOR', 'FINALLY']
           tokens.splice i + j, 0, @indentation()...
           return 2 + j
-      if tag in ['->', '=>'] and @tag(i + 1) in [',', '.']
+      if tag in ['->', '=>'] and (@tag(i + 1) is ',' or @tag(i + 1) is '.' and token.newLine)
         [indent, outdent] = @indentation tokens[i]
         tokens.splice i + 1, 0, indent, outdent
         return 1

diff --git a/test/error_messages.coffee b/test/error_messages.coffee
@@ -1601,6 +1601,16 @@ test 'Bound method called as callback before binding throws runtime error', ->
       ok no
   d = new Derived
 
+test "#3845/#3446: chain after function glyph (but not inline)", ->
+  assertErrorFormat '''
+    a -> .b
+  ''',
+  '''
+    [stdin]:1:6: error: unexpected .
+    a -> .b
+         ^
+  '''
+
 test "#3906: error for unusual indentation", ->
   assertErrorFormat '''
     a