Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2] Destructuring object spreads #4493

Merged
merged 90 commits into from
Jun 30, 2017
Merged

[CS2] Destructuring object spreads #4493

merged 90 commits into from
Jun 30, 2017

Commits on Feb 5, 2017

  1. Don’t confuse the syntax highlighter

    @GeoffreyBooth
    GeoffreyBooth committed Feb 5, 2017
    Configuration menu
    Copy the full SHA
    17511d4 View commit details
    Browse the repository at this point in the history

  2. Comment Assign::compilePatternMatch a bit

    @lydell
    lydell committed Feb 5, 2017
    Configuration menu
    Copy the full SHA
    590cd3f View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2017

  1. Merge branch 'destructuring-comments' of github.com:lydell/coffee-scr… 

    …ipt into destructuring
    @GeoffreyBooth
    GeoffreyBooth committed Feb 6, 2017
    Configuration menu
    Copy the full SHA
    f0ebb0a View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2017

  1. Assignment expressions in conditionals are a bad practice

    @GeoffreyBooth
    GeoffreyBooth committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    1b2d847 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2017

  1. Merge branch '2' into destructuring

    @GeoffreyBooth
    GeoffreyBooth committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    d3278b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2017

  1. Rename wrapInBraces to wrapInParentheses, to set the stage for fu… 

    …ture `wrapInBraces` that uses `{` and `wrapInBrackets` that uses `[`
    @GeoffreyBooth
    GeoffreyBooth committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    11d6c59 View commit details
    Browse the repository at this point in the history

  2. Correct comment

    @GeoffreyBooth
    GeoffreyBooth committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    5224e76 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2017

  1. object destructuring

    Zdenko Vujasinovic committed Mar 26, 2017
    Configuration menu
    Copy the full SHA
    d8cca79 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2017

  1. Allow custom position of the rest element.

    Zdenko Vujasinovic committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    49001d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2017

  1. Output simple array destructuring assignments to ES2015

    Chris Connelly committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    59959a6 View commit details
    Browse the repository at this point in the history

  2. Output simple object destructured assignments to ES2015

    Chris Connelly committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    b9f8f5d View commit details
    Browse the repository at this point in the history

  3. Compile shorthand object properties to ES2015 shorthand properties 

    This dramatically improves the appearance of destructured imports.
    Chris Connelly committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    066071f View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2017

  1. Don’t confuse the syntax highlighter

    @GeoffreyBooth
    GeoffreyBooth authored and Zdenko Vujasinovic committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    429ab12 View commit details
    Browse the repository at this point in the history

  2. Comment Assign::compilePatternMatch a bit

    @lydell
    lydell authored and Zdenko Vujasinovic committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    d60053a View commit details
    Browse the repository at this point in the history

  3. Assignment expressions in conditionals are a bad practice

    @GeoffreyBooth
    GeoffreyBooth authored and Zdenko Vujasinovic committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    9ea695a View commit details
    Browse the repository at this point in the history

  4. Rename wrapInBraces to wrapInParentheses, to set the stage for fu… 

    …ture `wrapInBraces` that uses `{` and `wrapInBrackets` that uses `[`
    @GeoffreyBooth
    GeoffreyBooth authored and Zdenko Vujasinovic committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    c4761cb View commit details
    Browse the repository at this point in the history

  5. object destructuring

    Zdenko Vujasinovic committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    840b4a4 View commit details
    Browse the repository at this point in the history

  6. Allow custom position of the rest element.

    Zdenko Vujasinovic committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    c26164e View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2017

  1. rest element in object destructuring

    Zdenko Vujasinovic committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    f36ae29 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2017

  1. rest element in object destructuring

    Zdenko Vujasinovic committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    c8b63eb View commit details
    Browse the repository at this point in the history

  2. fix string interpolation

    Zdenko Vujasinovic committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    9a17905 View commit details
    Browse the repository at this point in the history

  3. merge

    Zdenko Vujasinovic committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    b7bb4c9 View commit details
    Browse the repository at this point in the history

  4. merging

    Zdenko Vujasinovic committed Apr 2, 2017
    Configuration menu
    Copy the full SHA
    25b1ab6 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2017

  1. fixing splats in object literal

    Zdenko Vujasinovic committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    8984f2e View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2017

  1. Rest element in parameter destructuring

    Zdenko Vujasinovic committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    d65b247 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2017

  1. merging with CS2

    Zdenko Vujasinovic committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    35e9646 View commit details
    Browse the repository at this point in the history

  2. merging with CS2

    Zdenko Vujasinovic committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    2326a5b View commit details
    Browse the repository at this point in the history

  3. merged with CS2

    Zdenko Vujasinovic committed Apr 9, 2017
    Configuration menu
    Copy the full SHA
    d9c84cd View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2017

  1. Add support for the object spread initializer. https://github.com/tc3… 

    …9/proposal-object-rest-spread/blob/master/Spread.md
    Zdenko Vujasinovic committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    55e0b62 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2017

  1. Merge branch '2' of github.com:jashkenas/coffeescript into destructur… 

    …ing_object

# Conflicts:
#	lib/coffeescript/nodes.js
#	lib/coffeescript/parser.js
    @GeoffreyBooth
    GeoffreyBooth committed May 7, 2017
    Configuration menu
    Copy the full SHA
    7045a35 View commit details
    Browse the repository at this point in the history

  2. Fix misspellings, trailing whitespace, other minor details

    @GeoffreyBooth
    GeoffreyBooth committed May 7, 2017
    Configuration menu
    Copy the full SHA
    12931fe View commit details
    Browse the repository at this point in the history

Commits on May 30, 2017

  1. merging with beta2

    Zdenko Vujasinovic committed May 30, 2017
    Configuration menu
    Copy the full SHA
    aed10ea View commit details
    Browse the repository at this point in the history

  2. merging with beta2

    Zdenko Vujasinovic committed May 30, 2017
    Configuration menu
    Copy the full SHA
    fc7a8fa View commit details
    Browse the repository at this point in the history

  3. refactor object spread properties

    Zdenko Vujasinovic committed May 30, 2017
    Configuration menu
    Copy the full SHA
    cc58cec View commit details
    Browse the repository at this point in the history

  4. refactor object spread properties

    Zdenko Vujasinovic committed May 30, 2017
    Configuration menu
    Copy the full SHA
    8417d0f View commit details
    Browse the repository at this point in the history

  5. small fix

    Zdenko Vujasinovic committed May 30, 2017
    Configuration menu
    Copy the full SHA
    a5f2708 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2017

  1. - Fixed object spread function parameters. 

    - Clean up "Assign" and moved all logic for object rest properties in single method (compileObjectDestruct).
- Add helper function "objectWithoutKeys" to the "UTILITIES" for use with object rest properties,
  e.g. {a, b, r...} = obj => {a, b} = obj, r = objectWithoutKeys(...)
- Clean up "Obj" and moved all logic for object spread properties in single method (compileSpread).
- Clean up "Code".
- Add method "hasSplat" to "Obj" and "Value" for checking if Obj contains the splat.
- Enable placing spread syntax triple dots on either right or left, per jashkenas#85 (coffeescript6/discuss#85)
    Zdenko Vujasinovic committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    d25576a View commit details
    Browse the repository at this point in the history

  2. Fixed typos

    Zdenko Vujasinovic committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    c544a37 View commit details
    Browse the repository at this point in the history

  3. Remove unused code

    Zdenko Vujasinovic committed Jun 4, 2017
    Configuration menu
    Copy the full SHA
    2e72646 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2017

  1. Removed dots (e.g. splat) on the left side from the grammar

    Zdenko Vujasinovic committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    4fcaec7 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2017

  1. Initial release for deep spread properties, e.g. obj2 = {obj.b..., a:… 

    … 1} or {obj[b][c]..., d: 7}

Tests need to be prepared!
    Zdenko Vujasinovic committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    d59be16 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2017

  1. 1. Object literal spread properties 

    Object literals:
- obj = { {b:{c:{d:1}}}..., a:1 }

Parenthetical:
- obj = { ( body ), a:1 }
- obj = { ( body )..., a:1 }

Invocation:
- obj = { ( (args) -> ... )(params), a:1 }
- obj = { ( (args) -> ... )(params)..., a:1 }
- obj = { foo(), a:1 }
- obj = { foo()..., a:1 }

2. Refactor, cleanup & other optimizations.
    Zdenko Vujasinovic committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    286d4c7 View commit details
    Browse the repository at this point in the history

  2. Merging with 2.0

    Zdenko Vujasinovic committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    c20a4d3 View commit details
    Browse the repository at this point in the history

  3. Merged with 2.0

    Zdenko Vujasinovic committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    06606c3 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2017

  1. Cleanup

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    37787ae View commit details
    Browse the repository at this point in the history

  2. Some more cleanup.

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    7d8fceb View commit details
    Browse the repository at this point in the history

  3. Fixed error with freeVariable and object destructuring.

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    9dfc148 View commit details
    Browse the repository at this point in the history

  4. Fixed errors with object spread properties.

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    4815aa4 View commit details
    Browse the repository at this point in the history

  5. Improvements, fixed errors.

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    085e0cb View commit details
    Browse the repository at this point in the history

  6. Minor improvement.

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    e170eee View commit details
    Browse the repository at this point in the history

  7. Minor improvements.

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    4bc224f View commit details
    Browse the repository at this point in the history

  8. Typo.

    Zdenko Vujasinovic committed Jun 12, 2017
    Configuration menu
    Copy the full SHA
    c4f112e View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2017

  1. Remove unnecessary whitespace.

    Zdenko Vujasinovic committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    41fbbf0 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary whitespace.

    Zdenko Vujasinovic committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    d7a3945 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2017

  1. Changed few "assertErrorFormat" tests since parentheses are now allow… 

    …ed in the Obj.
    Zdenko Vujasinovic committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    8ccc4d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2017

  1. Merged with 2

    Zdenko Vujasinovic committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    a24ba42 View commit details
    Browse the repository at this point in the history

  2. Whitespace cleanup

    @GeoffreyBooth
    GeoffreyBooth committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    a2eb546 View commit details
    Browse the repository at this point in the history

  3. Comments cleanup

    @GeoffreyBooth
    GeoffreyBooth committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    9dda2ba View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2017

  1. fix destructured obj param declarations

    @helixbass
    helixbass committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    f864463 View commit details
    Browse the repository at this point in the history

  2. refine fix; add test

    @helixbass
    helixbass committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    a339e16 View commit details
    Browse the repository at this point in the history

  3. Refactor function args ({a, b...})

    Zdenko Vujasinovic committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    deda22e View commit details
    Browse the repository at this point in the history

  4. Additional tests for object destructuring in function argument.

    Zdenko Vujasinovic committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    44337dc View commit details
    Browse the repository at this point in the history

  5. Minor improvement for object destructuring variable declaration.

    Zdenko Vujasinovic committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    b68d23a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2017

  1. refactor function args ({a, b...}) and ({a, b...} = {}); Obj And Para… 

    …m cleanup
    Zdenko Vujasinovic committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    83983c4 View commit details
    Browse the repository at this point in the history

  2. fix comment

    Zdenko Vujasinovic committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    7e536e3 View commit details
    Browse the repository at this point in the history

  3. Fix object destructuring variable declaration.

    Zdenko Vujasinovic committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    b2411c7 View commit details
    Browse the repository at this point in the history

  4. more tests with default values

    Zdenko Vujasinovic committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    515d981 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2017

  1. fix typo

    Zdenko Vujasinovic committed Jun 18, 2017
    Configuration menu
    Copy the full SHA
    2af867a View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2017

  1. Fixed default values in object destructuring.

    Zdenko Vujasinovic committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    3a90db9 View commit details
    Browse the repository at this point in the history

  2. small fix

    Zdenko Vujasinovic committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    2dd0439 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2017

  1. Merged in 2

    Zdenko Vujasinovic committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    ad29a18 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2017

  1. Babel’s tests for object rest spread

    @GeoffreyBooth
    GeoffreyBooth committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    e10f8c4 View commit details
    Browse the repository at this point in the history

  2. Style: spaces after colons in object declarations

    @GeoffreyBooth
    GeoffreyBooth committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    ab23c7f View commit details
    Browse the repository at this point in the history

  3. Cleanup comments

    @GeoffreyBooth
    GeoffreyBooth committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    f718fa7 View commit details
    Browse the repository at this point in the history

  4. Simplify Babel tests

    @GeoffreyBooth
    GeoffreyBooth committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    0ef94a1 View commit details
    Browse the repository at this point in the history

  5. Fix comments

    @GeoffreyBooth
    GeoffreyBooth committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    5163634 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2017

  1. Fix destructuring with splats in multiple objects

    @connec
    connec committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    ec5d2c0 View commit details
    Browse the repository at this point in the history

  2. Add test for default values in detsructuring assignment with splats

    @connec
    connec committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    4752477 View commit details
    Browse the repository at this point in the history

  3. Handle default values when assigning to object splats

    @connec
    connec committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    2dd0709 View commit details
    Browse the repository at this point in the history

  4. Rewrite traverseRest to fix handling of dynamic keys

    @connec
    connec committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    4c8af9c View commit details
    Browse the repository at this point in the history

  5. Fix double parens around destructuring with splats

    @connec
    connec committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    dab4a12 View commit details
    Browse the repository at this point in the history

  6. Update compileObjectDestruct comments

    @connec
    connec committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    7d7f4e6 View commit details
    Browse the repository at this point in the history

  7. Improve formatting of top-level destructures with splats and tidy parens

    @connec
    connec committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    620846e View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2017

  1. Added a bigger destructuring-with-defaults test and fixed a bug

    @connec
    connec committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    2dbc8b8 View commit details
    Browse the repository at this point in the history

  2. Refactor destructuring grammar to allow additional forms

    @connec
    connec committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    8ae0240 View commit details
    Browse the repository at this point in the history

  3. Add a missing case to ObjSpreadExpr

    @connec
    connec committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    e4f9c20 View commit details
    Browse the repository at this point in the history

  4. These tests shouldn’t run in the browser

    @GeoffreyBooth
    GeoffreyBooth committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    b333a92 View commit details
    Browse the repository at this point in the history

  5. Fix test.html

    @GeoffreyBooth
    GeoffreyBooth committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    6775b62 View commit details
    Browse the repository at this point in the history

  6. Merge branch '2' of github.com:jashkenas/coffeescript into destructur… 

    …ing_object

# Conflicts:
#	test/argument-parsing.coffee
    @GeoffreyBooth
    GeoffreyBooth committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    d189caf View commit details
    Browse the repository at this point in the history

  7. Merge branch '2' of github.com:jashkenas/coffeescript into destructur… 

    …ing_object
    @GeoffreyBooth
    GeoffreyBooth committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    1cd1463 View commit details
    Browse the repository at this point in the history