-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix REPL assignment #4559
Fix REPL assignment #4559
Conversation
I don’t understand what’s going on here. See #4528, which you were a part of too. We’re assigning to |
So … the Node.js REPL has this feature that As mentioned in a comment in the code, we add So this PR simply uses another name ( Everything works as before, with the exception that I just tried this PR and it seems to be working fine:
|
Okay, @lydell if you think it’s okay then I’m fine with it. What about tests? |
I’m not sure there very much to test? And |
A test that |
If @xixixao feels like writing a test then go for it, but if not it shouldn’t hold up this PR. There was no test before either. |
I'm not bothered. |
I'm not bothered |
Is no one ever using the REPL? The variable was never documented, but Node does this on its own, so you can access the last expression with both
_
and__
. No more annoying messages!!!