Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS2] Support await in REPL without wrapper function #4604

Merged
merged 2 commits into from
Jul 24, 2017
Merged

[CS2] Support await in REPL without wrapper function #4604

merged 2 commits into from
Jul 24, 2017

Commits on Jul 14, 2017

  1. Support await in REPL without wrapper function 

    Rather than compiling top-level await expressions directly, which will
always throw a syntax error, the REPL wrapper will now wrap them in a
closure and handle the returned promise before calling back to the REPL.

Fixes #4603.
    @connec
    connec committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    b323b90 View commit details
    Browse the repository at this point in the history

  2. Cancel REPL callback after a SIGINT during an awaited evaluation 

    This change allows users to 'cancel' awaited expressions that they don't
want to see the result of. Ultimately, this *does not* prevent the
expression from completing (e.g. for `await fetch(url)`, `url` will
still be downloaded, but the user won't have to wait for it to finish
and the result won't be printed).
    @connec
    connec committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    1c5ed12 View commit details
    Browse the repository at this point in the history