-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2] CSX spread attributes: <div {props…} /> #4607
Merged
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
da086b9
CSX spread attributes: <div {props...} />
8841e47
whitespace cleanup
a6172c0
Style
GeoffreyBooth c62be6b
valid CSX attributes
91a294b
added comments; cleanup
4a318fc
Fixed allowed CSX properties.
2d06fb1
Cleanup
e3d1546
Typo
00861f6
Improved RegEx
df30657
Merge branch '2' of github.com:jashkenas/coffeescript into csx-spreads
GeoffreyBooth 3bed4a4
Reworked CSX attributes
9da14a2
Merged
5908448
small fix for CSX attribute validation
437ff70
cleanup
b097188
tests
e86285b
fix nested assignement; remove unused variable
7de2eb9
cleanup; improve tests
ff8d4f2
fix esoteric case; improve tracking nested splats in CSX tag
bd3fd67
Merge branch '2' of github.com:jashkenas/coffeescript into csx-spreads
GeoffreyBooth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we reformat this line to something like:
It might also benefit from a comment stating what is allowed (e.g. what is
(propVal instanceof Parens or propVal instanceof StringWithInterpolations) and propVal.body instanceof Block
ensuring?).