Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify chain #1691

Merged
merged 1 commit into from
Jun 18, 2014
Merged

Simplify chain #1691

merged 1 commit into from
Jun 18, 2014

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jun 18, 2014

Styles it to be inherited to _.prototype with the rest of the functions

@braddunbar
Copy link
Collaborator

Beautiful! Thanks @megawac!

braddunbar added a commit that referenced this pull request Jun 18, 2014
@braddunbar
Merge pull request #1691 from megawac/chain
32b83af 
Simplify chain
@braddunbar braddunbar merged commit 32b83af into jashkenas:master Jun 18, 2014
@jdalton
Copy link
Contributor

jdalton commented Jun 18, 2014

A side effect of this

var a = _([1]);
var b = a.chain();
a === b; // => was `true` but with the patch will be `false`

@megawac megawac mentioned this pull request Aug 27, 2014
Merged
@jgonggrijp jgonggrijp mentioned this pull request Jun 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@megawac @braddunbar @jdalton @gyeates