Compiler: perform two rounds of range splitting #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first round, before expansion of register arrays, does not apply to cells of register arrays. The second round fixes this limitation.
vbgl
force-pushed
the
twice-live-range-splitting
branch
from
139fca6
to
0244409
Compare
|
I’ve refactored a bit to move the “live-range-splitting” pass into a separate function. CI: https://gitlab.com/jasmin-lang/jasmin/-/pipelines/765470868 |
bgregoir
approved these changes
Feb 3, 2023
|
I didn't take any look to what was done here. But a natural question arises. Is it not possible to run the pass only after reg array expansion? Or do reg array expansion earlier? |
|
Vincent tried but, it does not work. The first step, reduce the liveness of some variables and allows to have a better reg array expansion. |
|
The first round of live-range-splitting removes renaming assignments between arrays (e.g., |
vbgl
added a commit
that referenced
this pull request
Feb 6, 2023
The first round, before expansion of register arrays, does not apply to cells of register arrays. The second round fixes this limitation. (cherry picked from commit a5ff976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first round, before expansion of register arrays, does not apply to cells of register arrays. The second round fixes this limitation.
CI: https://gitlab.com/jasmin-lang/jasmin/-/pipelines/765177635