Skip to content

Commit

Permalink
http2: significant internal refactoring
Browse files Browse the repository at this point in the history
* tighten up the Http2Stream/Http2Session lifecycle, destroy, and
  error handling. Some simplification, and more new tests

* Eliminate queuing of internal callbacks. Queuing these to fire on
  the next event loop tick was throwing off timing. Now the js callbacks
  are called directly as they happen. This will require a bit more
  finesse on the javascript side (to ensure appropiate timing of
  destroy/shutdown actions) but that is handled from within the core
  api impl so users should not be affected.

* fix debug output with nghttp2

PR-URL: nodejs#138
Reviewed-By: Matteo Collina <[email protected]>
  • Loading branch information
jasnell committed Jul 14, 2017
1 parent 619ce80 commit 6d90685
Show file tree
Hide file tree
Showing 32 changed files with 1,604 additions and 1,250 deletions.
4 changes: 3 additions & 1 deletion deps/nghttp2/nghttp2.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@
'lib/nghttp2_buf.h',
'lib/nghttp2_callbacks.c',
'lib/nghttp2_callbacks.h',
'lib/nghttp2_debug.c',
'lib/nghttp2_debug.h',
'lib/nghttp2_frame.c',
'lib/nghttp2_frame.h',
'lib/nghttp2_hd.c',
'lib/nghttp2_hd.h',
'lib/nghttp2_hd_huffman_data.c',
'lib/nghttp2_hd_huffman.c',
'lib/nghttp2_hd_huffman_data.c',
'lib/nghttp2_hd_huffman.h',
'lib/nghttp2_helper.c',
'lib/nghttp2_helper.h',
Expand Down
Loading

0 comments on commit 6d90685

Please sign in to comment.