feat: TypedDocumentNode support & strict variable typings #350
Conversation
|
Will try to look at this next week. |
|
|
||
| export type BatchRequestsOptions<V = Variables> = { | ||
| documents: BatchRequestDocument<V>[] | ||
| requestHeaders?: Dom.RequestInit['headers'] | ||
| signal?: Dom.RequestInit['signal'] | ||
| } | ||
|
|
||
| export type RequestExtendedOptions<V = Variables> = { url: string } & RequestOptions<V> | ||
| export type RequestExtendedOptions<V = Variables, T = any> = { url: string } & RequestOptions<V, T> |
There was a problem hiding this comment.
Let's rename T to what it is.
There was a problem hiding this comment.
Hi @jasonkuhrt,
I'm working with @n1ru4l at The Guild, making this PR move forward.
Regarding your point, the T naming is used everywhere for the result type, do you want me to change it everywhere or just there?
examples/typed-document-node.ts
Outdated
| console.log(data.greetings) | ||
| })().catch((error) => console.error(error)) | ||
|
|
||
| /** TypeScript API Tests */ |
There was a problem hiding this comment.
Move this to the test suite sommewhere.
|
@jasonkuhrt, I ran Do all the format changes in this PR looks ok, or should I revert them? |
It is fine, thanks! Yeah we need a format check in CI. |
jasonkuhrt
changed the title
|
Thanks, @jasonkuhrt! ⚡ |
This PR adds support for
TypedDocumentNodewhich is already adopted within clients such as urql or apollo and is widely used by people through@graphql-codegen/typed-document-nodeand@graphql-codegen/gql-tag-operations-preset.Resources: