Enhancements on window's thumbnails #71
Conversation
zqq90
changed the title
There was a problem hiding this comment.
I added some change request notes for some minor problems, but I really like this change and think it will make it easier for people to use this applet.
As for your question about adding a settings option, I think since we already made Super+# cycle through an app's windows, the thumbnail menu popup makes that more usable, so I don't think a new setting is needed.
| @@ -904,8 +917,7 @@ WindowThumbnail.prototype = { | |||
| this.actor.connect('leave-event', ()=>{ | |||
| if (!this.isFavapp) { | |||
| this._hoverPeek(OPACITY_OPAQUE, this.metaWindow, false) | |||
| this.actor.remove_style_pseudo_class('outlined') | |||
There was a problem hiding this comment.
Can you re-add these lines? This is causing the thumbnails to enlarge when cycling Super+#.
| @@ -953,6 +967,16 @@ WindowThumbnail.prototype = { | |||
| this.actor.remove_style_class_name('thumbnail-alerts') | |||
| } | |||
| }, | |||
|
|
|||
| _focusWindowChange: function () { | |||
| if (this._hasFocus()) { | |||
There was a problem hiding this comment.
I saw this error from ~/.xsession-errors:
(cinnamon:7207): Cjs-WARNING **: JS ERROR: TypeError: this.metaWindow is null
_hasFocus@/home/jason/.local/share/cinnamon/applets/IcingTaskManager@json/specialMenus.js:1037
_focusWindowChange@/home/jason/.local/share/cinnamon/applets/IcingTaskManager@json/specialMenus.js:1027
_init/<@/home/jason/.local/share/cinnamon/applets/IcingTaskManager@json/specialMenus.js:985
setTimeout/<@/home/jason/.local/share/cinnamon/applets/IcingTaskManager@json/__init__.js:10Maybe we should add this.metaWindow && this.metaWindow.minimized to Line 984 in specialMenus.js
There was a problem hiding this comment.
Or before those if blocks:
if (!this.metaWindow) {
return false
}…selected & outlined'
|
Another problem is, menus willn't close before release do you have any idea ? |
|
I'm not sure, when I switch app numbers with Super+#, it seems to behave as expected - as soon as Super is released the menu disappears - is this what you intend? |
|
@jaszhix |
|
Oh ok, I got it now. |
|
Ok, I think I fixed it with this commit. Can you test it? Edit: It fixes it but makes opening the menu require an extra key stroke. |
Two features:
BTW, should we add a switch the second one in settings?