Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to testScribe DataTypeConverter test failure. #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhuttana
Copy link

Could you please review the change?

@judovana
Copy link

maybe the best would be to get rid of the the base64 extenral impl and use the on i jf I read the #50 correctly

@jhuttana
Copy link
Author

maybe the best would be to get rid of the the base64 extenral impl and use the on i jf I read the #50 correctly

It is handled at some binary file level

$ grep -inr "base64"
grep: .gradle/5.2.1/javaCompile/classAnalysis.bin: binary file matches
grep: build/test-recompiled/org/apache/commons/codec/binary/Base64OutputStream.class: binary file matches
grep: build/test-recompiled/org/apache/commons/codec/binary/Base64InputStream.class: binary file matches
grep: build/test-recompiled/org/apache/commons/codec/binary/Base64.class: binary file matches
grep: build/test-recompiled/org/apache/commons/codec/net/BCodec.class: binary file matches
grep: build/test-recompiled/org/scribe/oauth/OAuth10aServiceImpl.class: binary file matches
grep: build/test-recompiled/org/scribe/services/HMACSha1SignatureService.class: binary file matches
grep: build/test-recompiled/org/scribe/services/Base64Encoder.class: binary file matches
grep: build/test-recompiled/org/scribe/services/DatatypeConverterEncoder.class: binary file matches
grep: build/test-recompiled/org/scribe/services/RSASha1SignatureService.class: binary file matches
grep: build/test-recompiled/org/scribe/services/CommonsEncoder.class: binary file matches

So I don't think its possible.
The the root cause for this failure was 'Unable to find package javax.xml->Unable to find symbbol bind'.
The patch will address that directly.

@judovana
Copy link

Well, sure. But those deps will disapear if the proper base64 from jdk itself is used.

@jhuttana
Copy link
Author

Well, sure. But those deps will disapear if the proper base64 from jdk itself is used.

May be :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants