Advapi32Util.registryGetValues() returns no results if the key contains an empty REG_BINARY value

[ghost]

Not much else to say but this a bit serious for what I'm working on at the moment.

How to reproduce:

1. Open up regedit
2. Create a registry key and add an empty REG_BINARY value
3. Add a couple of other values
4. Then try this:
   System.out.println(Advapi32Util.registryGetValues(WinReg.HKEY_CURRENT_USER, "your_key_here").size());

You will see that it returns 0 entries, even though there are several actually there. If you remove that binary value, registryGetValues() will magically work again.

[twall]

If you could augment the existing unit tests to reproduce this fault it would speed up getting a fix.

On Sep 3, 2012, at 11:51 PM, phailwhale22 wrote:

Not much else to say but this a bit serious for what I'm working on at the moment.

How to reproduce:

1. Open up regedit
2. Create a registry key and add an empty REG_BINARY value
3. Add a couple of other values

• Then try this: System.out.println(Advapi32Util.registryGetValues(WinReg.HKEY_CURRENT_USER, "your_key_here").size());
You will see that it returns 0 entries, even though there are several actually there. If you remove that binary value, registryGetValues() will magically work again.

—
Reply to this email directly or view it on GitHub.

[ghost]

I'm feeling a bit dumb now, I had a try..catch block around my call to registryGetValues(). Here is the exception that it was throwing:

Exception in thread "main" java.lang.IllegalArgumentException: Allocation size must be greater than zero
at com.sun.jna.Memory.(Memory.java:88)
at com.sun.jna.platform.win32.Advapi32Util.registryGetValues(Advapi32Util.java:1265)
at com.sun.jna.platform.win32.Advapi32Util.registryGetValues(Advapi32Util.java:1327)

[ghost]

Oops, accidentally closed the issue...

[dblock]

Looks like a bug, https://github.com/twall/jna/blob/master/contrib/platform/src/com/sun/jna/platform/win32/Advapi32Util.java#L1265 is allocating memory when in fact there's none (empty binary value). Should be an easy fix, @phailwhale22 want to try a unit test that reproduces it (in https://github.com/twall/jna/blob/master/contrib/platform/test/com/sun/jna/platform/win32/Advapi32UtilTest.java) and maybe a fix?