Build broken and not reporting failure #464

dblock · 2015-07-06T11:20:13Z

On OSX: https://travis-ci.org/twall/jna/jobs/69478093#L636

   [javac] Compiling 66 source files to /home/travis/build/twall/jna/contrib/platform/build/test/classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
    [javac] /home/travis/build/twall/jna/contrib/platform/test/com/sun/jna/platform/mac/SystemBTest.java:20: error: package oshi.software.os.mac.local.SystemB does not exist
    [javac] import oshi.software.os.mac.local.SystemB.HostCpuLoadInfo;
    [javac]                                          ^
    [javac] /home/travis/build/twall/jna/contrib/platform/test/com/sun/jna/platform/mac/SystemBTest.java:21: error: package oshi.software.os.mac.local.SystemB does not exist
    [javac] import oshi.software.os.mac.local.SystemB.HostLoadInfo;
    [javac]                                          ^
    [javac] /home/travis/build/twall/jna/contrib/platform/test/com/sun/jna/platform/mac/SystemBTest.java:22: error: package oshi.software.os.mac.local.SystemB does not exist
    [javac] import oshi.software.os.mac.local.SystemB.VMStatistics;
    [javac]                                          ^
    [javac] /home/travis/build/twall/jna/contrib/platform/test/com/sun/jna/platform/mac/SystemBTest.java:23: error: package oshi.software.os.mac.local.SystemB does not exist
    [javac] import oshi.software.os.mac.local.SystemB.VMStatistics64;
    [javac]                                          ^
    [javac] /home/travis/build/twall/jna/contrib/platform/test/com/sun/jna/platform/mac/SystemBTest.java:89: error: cannot find symbol
    [javac]         VMStatistics vmStats = new VMStatistics();
    [javac]         ^

The text was updated successfully, but these errors were encountered:

twall · 2015-07-06T13:45:39Z

@PAX523 it looks like when this was committed we didn't get a full update, the test is still referencing local changes rather than the updated VMStatistics64 (nor are VMStatistics* structures actually referenced by any mapped calls to vm_statistics[64].

twall · 2015-07-06T15:34:36Z

Apparently host_statistics can accept a variety of structures depending on the other parameters.

twall · 2015-07-06T15:46:44Z

@dblock is there a general issue with travis not reporting platform test failures?

dbwiddis · 2015-07-06T16:51:12Z

My apologies. Copy-paste stupidity. Is this fixed or do you need anything from me now?

I actually have another method to add to this structure that I'll submit separately (and doublecheck the tests!)

twall · 2015-07-06T18:42:34Z

The build is fixed, and the OS X tests pass, so we only need you to double check your tests are still doing what they were originally intended to.

On Jul 6, 2015, at 12:51 PM, dbwiddis [email protected] wrote:

My apologies. Copy-paste stupidity. Is this fixed or do you need anything from me now?

I actually have another method to add to this structure that I'll submit separately (and doublecheck the tests!)

—
Reply to this email directly or view it on GitHub.

PAX523 · 2015-07-06T18:53:58Z

Hallo Timothy.
Are these builds really affected by my recent contribution? Actually, I didn't touch code which is concerned with OS X code?
Cheers PAX

dbwiddis · 2015-07-06T19:24:41Z

PAX,

No, the errors were mine. You can ignore this thread.

Dan

On 7/6/15 11:54 AM, PAX523 wrote:

Hallo Timothy.
Are these builds really affected by my recent contribution? Actually,
I didn't touch code which is concerned with OS X code?
Cheers PAX

Von: Timothy Wall [email protected]
An: twall/jna [email protected]
CC: PAX523 [email protected]
Gesendet: 20:42 Montag, 6.Juli 2015
Betreff: Re: [jna] Build broken and not reporting failure (#464)

The build is fixed, and the OS X tests pass, so we only need you to
double check your tests are still doing what they were originally
intended to.

On Jul 6, 2015, at 12:51 PM, dbwiddis [email protected] wrote:

My apologies. Copy-paste stupidity. Is this fixed or do you need
anything from me now?

I actually have another method to add to this structure that I'll
submit separately (and doublecheck the tests!)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#464 (comment).

twall · 2015-07-06T19:36:53Z

Sorry, my mistake. You did have some WindowUtils changes that were windows-specific which I moved to win32-only tests. While conceivably some of the functions might be possible to implement cross-platform, some of them are definitely windows only. DesktopWindow is definitely windows-only, as are the methods getWindowIcon, getWindowTitle, getIconSize, getAllWindows, getWindowLocationAndSize, and getProcessFilePath. These need to be refactored if they’re to be cross-platform; if not they belong in the win32 subdirectory.

On Jul 6, 2015, at 2:54 PM, PAX523 [email protected] wrote:

Hallo Timothy.
Are these builds really affected by my recent contribution? Actually, I didn't touch code which is concerned with OS X code?
Cheers PAX

Von: Timothy Wall [email protected]
An: twall/jna [email protected]
CC: PAX523 [email protected]
Gesendet: 20:42 Montag, 6.Juli 2015
Betreff: Re: [jna] Build broken and not reporting failure (#464)

The build is fixed, and the OS X tests pass, so we only need you to double check your tests are still doing what they were originally intended to.

On Jul 6, 2015, at 12:51 PM, dbwiddis [email protected] wrote:

My apologies. Copy-paste stupidity. Is this fixed or do you need anything from me now?

I actually have another method to add to this structure that I'll submit separately (and doublecheck the tests!)

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.

dblock · 2015-07-06T20:17:53Z

@twall I think JNA build is not properly reporting a non-zero error code when tests fail, that's a real bug in the build scripts somewhere

twall · 2015-07-06T20:30:40Z

I think that’s a setting within the test target; the platform build.xml is probably not propagating test failures to the parent process like the top level build.xml does. I’ll take a look.

On Jul 6, 2015, at 4:17 PM, Daniel Doubrovkine (dB.) @dblockdotorg [email protected] wrote:

@twall I think JNA build is not properly reporting a non-zero error code when tests fail, that's a real bug in the build scripts somewhere

—
Reply to this email directly or view it on GitHub.

fixed #464

Motivation: In order to support `native-image`, the project has to provide the corresponding configuration for reflection, JNI and resources. Modifications: - Module `codec-native-quic`: Add profile `native-image-agent` for generating `native-image` configuration - New module `testsuite-native-image`: Add profiles `native-image-quic-server`/`native-image-quic-client` for testing the `native-image` configuration Result: Fixes java-native-access#464

This was referenced Jul 6, 2015

fixed #460 #461

Merged

Mac OS X System.B library including sysctl() and host_statistics() #452

Merged

twall closed this as completed in a0954ce Jul 6, 2015

twall added a commit that referenced this issue Jul 10, 2015

Merge pull request #465 from sakamotodesu/not_reporting_failure

6d1ba51

fixed #464

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build broken and not reporting failure #464

Build broken and not reporting failure #464

dblock commented Jul 6, 2015

twall commented Jul 6, 2015

twall commented Jul 6, 2015

twall commented Jul 6, 2015

dbwiddis commented Jul 6, 2015

twall commented Jul 6, 2015

PAX523 commented Jul 6, 2015

dbwiddis commented Jul 6, 2015

twall commented Jul 6, 2015

dblock commented Jul 6, 2015

twall commented Jul 6, 2015

Build broken and not reporting failure #464

Build broken and not reporting failure #464

Comments

dblock commented Jul 6, 2015

twall commented Jul 6, 2015

twall commented Jul 6, 2015

twall commented Jul 6, 2015

dbwiddis commented Jul 6, 2015

twall commented Jul 6, 2015

PAX523 commented Jul 6, 2015

dbwiddis commented Jul 6, 2015

twall commented Jul 6, 2015

dblock commented Jul 6, 2015

twall commented Jul 6, 2015