Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split jpms modules into independet artifacts instead of classifier based solution #1317

Merged

Commits on Feb 22, 2021

  1. Split jpms modules into independet artifacts instead of classifier ba…

    …sed solution
    
    The jna-platform artifact depends on jna - this leads to problems when
    the JPMS artifacts are used, as the pom.xml for the classifier based
    artifacts are identical to the base artifacts. This leads to
    
      <dependency>
        <groupId>net.java.dev.jna</groupId>
        <artifactId>jna-platform</artifactId>
        <version>5.7.0</version>
        <classifier>jpms</classifier>
      </dependency>
    
    depending on
    
      <dependency>
        <groupId>net.java.dev.jna</groupId>
        <artifactId>jna</artifactId>
        <version>5.7.0</version>
      </dependency>
    
    so the jna-platform JPMS artifacts pulls in the non-JPMS jna artifact.
    
    To solve this, the JPMS artifacts are moved to custom artifact ids. So
    
      <dependency>
        <groupId>net.java.dev.jna</groupId>
        <artifactId>jna-platform</artifactId>
        <version>5.8.0</version>
        <classifier>jpms</classifier>
      </dependency>
    
    becomes
    
      <dependency>
        <groupId>net.java.dev.jna</groupId>
        <artifactId>jna-platform-jpms</artifactId>
        <version>5.8.0</version>
      </dependency>
    matthiasblaesing committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    b797901 View commit details
    Browse the repository at this point in the history