Added SetupDiOpenDevRegKey(..), SetupDiEnumDeviceInfo(..) and some constants #335
Conversation
SetupDiEnumDeviceInfo(..) and some constants associated with it.
| @@ -31,49 +35,102 @@ | |||
| /** | |||
| * The GUID_DEVINTERFACE_DISK device interface class is defined for hard disk storage devices. | |||
| */ | |||
| public static Guid.GUID GUID_DEVINTERFACE_DISK = new Guid.GUID(new byte[] | |||
| GUID GUID_DEVINTERFACE_DISK = new GUID(new byte[] | |||
There was a problem hiding this comment.
Should probably rewrite this one as new GUID with a string as well. This is a silly optimization.
There was a problem hiding this comment.
I didn't write that line, but yeah i can be improved.
|
This is good, needs a bit of work. Please also update CHANGELOG. |
|
Are the changes okay or is there more work needed? |
| @@ -13,6 +13,7 @@ Features | |||
| * Added Winspool monitor sample and updated Kernel32, WinBase, Winspool - [@wolftobias](https://github.com/wolftobias). | |||
| * Added Some minor changes to MS Office samples Test and small changes to the MS Office samples Bug Fixes - [@wolftobias](https://github.com/wolftobias). | |||
| * [#333](https://github.com/twall/jna/pull/333): Added `CoTaskMemAlloc`, `CoTaskMemRealloc` and `CoTaskMemFree` to `com.sun.jna.platform.win32.Ole32` - [@msteiger](https://github.com/msteiger). | |||
| * [#335](https://github.com/twall/jna/pull/335): Added `SetupDiOpenDevRegKey(..)`, `SetupDiEnumDeviceInfo(..)` and some constants to win32 SetupApi`- [@ChristianSchwarz](https://github.com/ChristianSchwarz) | |||
There was a problem hiding this comment.
Make this look like all the other changelog items.
- Period at the end.
- No
(..). - Write the full class name where this is added, JNA is not just Win32.
|
Added some more comments. This is very close. Can you also please rebase/squash these commits so that this is mergeable. Thx. |
| import com.sun.jna.ptr.IntByReference; | ||
| import com.sun.jna.win32.StdCallLibrary; | ||
| import com.sun.jna.win32.W32APIOptions; | ||
|
|
||
| /** | ||
| * The interface for the w32 setup API. | ||
| * @author Christian Schwarz |
There was a problem hiding this comment.
You didn't write the whole thing, right? You should remove this or fish all the names from git history and add them too.
|
Feel free to reject this pull request, i have no time to finish it. |
|
Lets leave it open in case someone wants to. |
|
I closed this cause made a new PR for this, see-> #419 |
Motivation: Trying to use wget to download cmake gives certificate errors. Using curl fixes it Modifications: Switch to curl to download cmake Result: Be able to build docker image again
I added the following items to the Win32 SetupApi
The JavaDocs are copied from MSDN, is this a legal problem?