openExcelBook never uses the parameter bVisible. #354
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That parameter is distracting.
|
I believe a test is causing this to fail. However the parameter is not used in any functional capacity. |
|
Thanks for this @monksy, I don't have a VM handy to run this, what's the failure output before and the successful run after? I'd merge without trying if it's convincing enough :) |
|
The change requested/implemented here was also part #649 - closing this. |
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
Motivation: A new netty-build release is out. Modifications: - Upgrade version - Adjust code to match new checkstyle rules Result: Use latest netty-build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That parameter is distracting.