Make native debug flags toggleable at runtime #512
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twall
added a commit
that referenced
this pull request
Sep 29, 2015
Make native debug flags toggleable at runtime
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
java-native-access#512) … a memory adress that is directly accessible. Motivation: When we try to obtain a memory address of a ByteBuf we might need to fallback to obain it via the ByteBuffer. When doing so we also need to take the position of the ByteBuffer into account as it might be non-zero. Modifications: - Add new static helper methods to Quiche class that can be used to obtain the reader / writer memory address in a consistent / easy manner. - Use these new methods Result: Always use the correct memory address and so don't end up with data-corruption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason why these debug flags cannot be changed during runtime?