Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate building of idea jar #528

Merged
merged 5 commits into from
Dec 4, 2015

Conversation

lwahonen
Copy link

@lwahonen lwahonen commented Nov 1, 2015

As discussed in #523, providing a build-target for this makes more sense than distributing it. I think I also want to add a mention about it to under /www, but I wasn't sure if the platform-specific documents (WindowsDevelopmentEnvironment.md etc) are the right place.

@twall
Copy link
Contributor

twall commented Nov 1, 2015

For documentation, I think a general page for IDE integration would make sense, linked to from the main.

@@ -12,6 +12,7 @@ Features
* [#512](https://github.com/java-native-access/jna/pull/512): Make loading debug flags mutable [@lwahonen](https://github.com/lwahonen).
* [#514](https://github.com/java-native-access/jna/pull/514): Added `host_processor_info` to `com.sun.jna.platform.mac.SystemB` - [@dbwiddis](https://github.com/dbwiddis).
* [#519](https://github.com/java-native-access/jna/pull/519): Added JNA functional overview - [@twall](https://github.com/twall).
* [#528](https://github.com/java-native-access/jna/pull/528): Add an ant task (idea-jar) that creates a convenience jar that contains all native dispatch libraries. If you want to hacking on JNA with an IDE, just include idea-dispatch.jar to your classpath and create a module from the JNA src directory. - [@lwahonen](https://github.com/lwahonen).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but this is too long for a CHANGELOG. If it needs to be documented it should go elsewhere in a build environment section or something like that. Just make this:

Added idea-jar ant task that creates a convenience jar that contains all native dispatch libraries - [@lwahonen](...).

@lwahonen
Copy link
Author

lwahonen commented Dec 4, 2015

I'm not sure how to nix that glitch commit+revert from there. https://xkcd.com/1597/ is relevant again

twall added a commit that referenced this pull request Dec 4, 2015
@twall twall merged commit 97978a0 into java-native-access:master Dec 4, 2015
@lwahonen lwahonen deleted the automate_ideajar branch December 4, 2015 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants