Added EnumResourceTypes and EnumResourceNames to Kernel32 #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -741,6 +744,8 @@ public static final String extractVolumeGUID(String volumeGUIDPath) { | |||
| if (start == null) { | |||
| throw new IllegalStateException("LockResource returned null."); | |||
| } | |||
| // have to capture it into a byte array before you free the library, otherwise bad things happen. | |||
| results = start.getByteArray(0, length); | |||
There was a problem hiding this comment.
This was the mistake. If you don't get the resource into a byte array before calling FreeLibrary() you're doomed.
|
Please try to write at least minimal tests for the individual This PR needs to be rebased against master, too, please. |
|
Added unit tests for the two functions to Kernel32Test.java and rebased against master. |
dblock
added a commit
that referenced
this pull request
Dec 1, 2015
Added EnumResourceTypes and EnumResourceNames to Kernel32
|
Merged, thank you. |
|
Btw, if anyone is into the whole win32 resources game, a similar project to https://github.com/dblock/resourcelib could probably be useful in Java. |
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…e-access#545) Motivation: There is a bug when doing 0RTT and task offloading. Let's disable the test for now until I have time to investigate Modifications: Disable test when offloading is done. Result: Stabilize build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes an embarassing mistake I made in Kernel32Util.getResource().
Like an idiot, I committed it to the branch on my fork, wandered off for a few days, came back, and created the last PR without realizing I'd never run the unit test.