Mavenize the build process - Phase 1: building the native code via Maven, by lgoldstein. Minor tweaks by bhamail. see PR #582 for details. #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <property name="jna.parent.folder" value="${module.root.folder}" /> | ||
| <import file="${jna.parent.folder}${file.separator}build-base.xml" /> | ||
|
|
||
| <tstamp> |
There was a problem hiding this comment.
What's up with the inconsistent indentation?
There was a problem hiding this comment.
Fixed in PR #597, replaced tabs with spaces.
|
This might be easier to collaborate on if you guys just made a branch in the core repo. Y'all are developers on java-native-access/jna so there's no need to fork. |
|
fixed by PR #597 |
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
Motivation: Let's update to latest quiche sha. Modifications: - Update to latest quiche sha - Fix QuicConnectionStats to be able to compile against latest sha Result: Use latest quiche code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on PR #582 from @lgoldstein (#582)
Apologies for my failed attempts to squash/rebase. Will do better next time.