Correct typemapper used for structures defined #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is incomplete, as the other files modified by #541 need to be checked. Please don't merge I'll revisit this. |
| } | ||
|
|
||
| public SHARE_INFO_2(Pointer memory) { | ||
| super(memory); | ||
| super(memory, Structure.ALIGN_DEFAULT, W32APITypeMapper.UNICODE); |
There was a problem hiding this comment.
Is this structure only valid in its unicode form?
There was a problem hiding this comment.
Jepp - both:
- SHARE_INFO_2 (https://msdn.microsoft.com/en-us/library/windows/desktop/bb525408(v=vs.85).aspx)
- SHARE_INFO_502 (https://msdn.microsoft.com/de-de/library/windows/desktop/bb525410(v=vs.85).aspx)
declare their string members as LPWSTR
|
Ok - with the updates of the typemappings and the updated tests I'm down to a few flaky tests. On x86 I'm seeing a consistent failure in the tests, that utilize MonitorFromPoint which return NULL on x86. The definition looks sane so I'll ignore it for now. |
| @@ -39,6 +39,12 @@ public static void main(String[] args) throws Exception { | |||
| junit.textui.TestRunner.run(MprTest.class); | |||
| } | |||
|
|
|||
| public void testCreateLocalShare() throws Exception { | |||
There was a problem hiding this comment.
createLocalShare was just a private helper function for the other tests, so I wouldn't say it needs its own test. But of course, it can't hurt.
matthiasblaesing
force-pushed
the
winnetwk_mapping
branch
2 times, most recently
from
fe19eca
to
2e031ba
Compare
Winnetwk definitions follow the typemapper set by the "w32.ascii" property, following the convention demonstrated/used in W32APIOptions.DEFAULT. The definitions in LMShare are defined as pure UNICODE. Closes: java-native-access#668
- Registry Keys are documented as case insensitive https://msdn.microsoft.com/de-de/library/windows/desktop/ms724946(v=vs.85).aspx - Improve stability of COM Tests by killing IE to ensure clean state - Prevent failures because of wrong locale (skip error message generation tests or use locale independent API) - OpenProcess with correct permissions - Free correct value in Secur32Test - Tolerate more complex scenarios in VolumeManagementFunctions (hidden partions) - Handle DxvaTest when monitor does not supply capablilities string - Use correct comparison operator for version check - Tolerate invalid environment strings - MonitorFromPoint is known to fail on 32bit => use MonitorFromWindow
matthiasblaesing
force-pushed
the
winnetwk_mapping
branch
from
2e031ba
to
9049d05
Compare
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
…ess#686) Motivation: QuicheQuicCodec keeps state and so can not be sharable, let's enforce this. Modifications: - Override isSharable() and return false Result: Ensure sub-types can not be sharable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Winnetwk definitions follow the typemapper set by the "w32.ascii"
property, following the convention demonstrated/used in
W32APIOptions.DEFAULT.
The definitions in LMShare are defined as pure UNICODE.
Closes: #668