Solaris Kstat library

[dbwiddis]

No description provided.

[dbwiddis]

This is failing Travis CI tests because it can't find libkstat which is only present on Solaris (SunOS). Either jna-platform's build.xml line 154 should exclude the package location I put these classes in (but I'm not sure how to do that), or I should move the packages, but I'm not sure the best place to put them.

[twall]

Follow the pattern for other platform-specific tests - OSX, unix, and windows have such (or if the library isn't guaranteed to be installed, make an explicit check for the library within the test itself by catching an UnsatisfiedLinkError when trying to load it).

…

On Sun, Apr 2, 2017 at 7:50 PM, dbwiddis ***@***.***> wrote: This is failing Travis CI tests because it can't find libkstat <http://docs.oracle.com/cd/E23824_01/html/821-1464/libkstat-3lib.html> which is only present on Solaris (SunOS). Either jna-platform's build.xml line 154 should exclude the package location I put these classes in (but I'm not sure how to do that), or I should move the packages, but I'm not sure the best place to put them. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#784 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuMreXel3Obc9fSxi1RhRkNO5SwV2f-ks5rsDQrgaJpZM4Mw9-c> .

[dbwiddis]

The libkstat should always be there on Solaris but not other Unices. I added a check for Platform.isSolaris() on the tests and Travis seems happy now.

Should be ready to merge or, if desired:

• I wrote several convenience methods to access the library that I have in my own application in a util class, that I included in the test class as private methods. I think this is probably sufficient for reference for anyone wanting to use this library. If desired I can split those methods out into a separate util class, however.

[matthiasblaesing]

Thank you - I'm not an expert but I had a quick look at the documentation and the structures and they look sane.

Could you please adjust the license headers of the newly added files to align with the AL2.0 + LGPL2.1 and newer combo license. See here:

https://github.com/java-native-access/jna/blob/master/www/Contributing.md#copyright-headers-in-files

With regard to the utility methods: Most C interfaces feel awkward when called from java and utility methods wrapping them help IMHO. If you think it is worth it, please go ahead.

[dbwiddis]

Headers updated. I left the utility methods in test since they would have log messages (or fail() messages in the test), and I don't see that JNA has any logging functionality.

[matthiasblaesing]

Unittests run cleanly on solaris 11.3, structures look sane, requested changes to new files were done.

Thank you, merged.