Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SuppressWarnings unused and other code cleanup #880

Closed
wants to merge 1 commit into from
Closed

Add SuppressWarnings unused and other code cleanup #880

wants to merge 1 commit into from

Conversation

Sylvyrfysh
Copy link

Fixes RandomAccessFile raf not being closed in ELFAnalyzer. Also removes the now unused field EF_ARM_ABI_FLOAT_SOFT from the same class. Other minor code cleanups, adding SuppressWarning unused's where native code calls occur (feel free to remove anything with that in it, I saw nothing in the contributing file that would suggest the use or refute it).

@matthiasblaesing
Copy link
Member

Thank you Nick, I separated the "RAF not closed" fix into #883 and #882. For the warning suppressions I see one suspect case (Native#detach), that might mask an actual bug, so I skipped these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants