-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current JAX release incompatible with numpy 1.21 #7052
Comments
I'm unsure why this crashes instead of just producing a warning, but typedict is a deprecated name (https://numpy.org/devdocs/release/1.21.0-notes.html#np-typedict-has-been-formally-deprecated) and apparently has been for 14 years. jax-ml/jax#7052 (although it seems likely the same issue applies to TF also) PiperOrigin-RevId: 380868551 Change-Id: I56a94e567d1996d710b4b4c786292cc44927a039
numpy/numpy#19305 is the source of one of the remaining errors. |
I've done all I plan to do on this for now: remaining is to release a new jaxlib (in progress) and to do something to fix or work around the numpy bug. |
Alright, I'll self-assign so I can close the issue after the next jaxlib release. |
Note that we can't close it until we do something to work around the numpy problem. It could just be skipping those tests under NumPy 1.21 for now. If you want to try running the tests before the new jaxlib lands, apply the following patch:
|
Part of the action item here may be to add a CI job to detect these kinds of breakages before release. @shoyer pointed out the approach that xarray uses, which is a github action that runs tests against upstream dev versions and opens a github issue in case of failure: https://github.com/pydata/xarray/blob/main/.github/workflows/upstream-dev-ci.yaml |
Numpy 1.21 was released a few hours ago, and appears incompatible with the current jaxlib release.
The text was updated successfully, but these errors were encountered: