Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node_spacing parameter for .text() similar to spacing, for number of pixels between nodes #27

Merged
merged 2 commits into from
May 8, 2023

Conversation

WitherredAway
Copy link
Contributor

This pull request adds an additional parameter to Pilmoji.text() that lets you specify the spacing between each node. This can come in handy as illustrated by the following example:

Before

Without the node_spacing parameter, you would have no choice but to accept this ugly spacing between each node (emoji in this case) on each line. You can pass in a negative value in the spacing parameter to deal with the line spacing, but there is no way to do that for between nodes
image

After

With the node_spacing parameter, you can pass in a negative value to deal with the spacing between nodes, and have smooth emoji arrays!
image

Note: I initially renamed spacing parameter to line_spacing to properly distinguish them, but that would be a breaking change and I'm not sure how you'd feel about that so I leave that up to you if you deem fit!

@jay3332
Copy link
Owner

jay3332 commented May 8, 2023

LGTM, thanks for the PR!

@jay3332 jay3332 merged commit 54edc7d into jay3332:2.0 May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants