Skip to content

Commit

Permalink
servicecontroller: remove unused zone field
Browse files Browse the repository at this point in the history
The zone field was unused, and this complicated e.g. kubernetes#39996
  • Loading branch information
justinsb authored and jayunit100 committed Apr 25, 2017
1 parent b0ca715 commit 26ee4a5
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions pkg/controller/service/servicecontroller.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ type ServiceController struct {
kubeClient clientset.Interface
clusterName string
balancer cloudprovider.LoadBalancer
zone cloudprovider.Zone
cache *serviceCache
serviceLister corelisters.ServiceLister
serviceListerSynced cache.InformerSynced
Expand Down Expand Up @@ -218,15 +217,6 @@ func (s *ServiceController) init() error {
}
s.balancer = balancer

zones, ok := s.cloud.Zones()
if !ok {
return fmt.Errorf("the cloud provider does not support zone enumeration, which is required for creating load balancers.")
}
zone, err := zones.GetZone()
if err != nil {
return fmt.Errorf("failed to get zone from cloud provider, will not be able to create load balancers: %v", err)
}
s.zone = zone
return nil
}

Expand Down

0 comments on commit 26ee4a5

Please sign in to comment.