Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPTIONS cannot be None given our code #232

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

palfrey
Copy link
Member

@palfrey palfrey commented Nov 8, 2023

As per the notes in #218

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0879f12) 100.00% compared to head (794bb78) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #232   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           75        75           
  Branches        18        18           
=========================================
  Hits            75        75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palfrey palfrey merged commit d23a2ca into jazzband:master Dec 9, 2023
14 checks passed
@palfrey palfrey deleted the no-optional-options branch December 9, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPTIONS key type for DBConfig is potentially incorrect
1 participant