Improved support for accessing models when using multiple databases #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Spikiii - The project has recently moved under a new team. If possible could you rebase this PR against Also, could you provide a unit test for you changes? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an issue that kept popping up in a work project that utilizes django-polymorphic. Specifically, the issue was that django-polymorphic didn't respect multiple databases for deletion, causing it to repeatedly error out if the object didn't exist in the
defaultdatabase, but did exist in thetarget_db.I've verified that this change passes the tests, as outlined in the community contribution guidelines.