-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 to test matrix and add classifier #689
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
=========================================
+ Coverage 63.3% 90.3% +27.1%
=========================================
Files 43 22 -21
Lines 3215 1346 -1869
Branches 244 0 -244
=========================================
- Hits 2034 1215 -819
+ Misses 1164 131 -1033
+ Partials 17 0 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2387901
to
9f5f8c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
.github/workflows/ci.yml
Outdated
@@ -90,7 +95,7 @@ jobs: | |||
- name: Install dependencies | |||
run: | | |||
python -m pip install --upgrade pip | |||
python -m pip install --upgrade "tox<4" tox-gh-actions | |||
python -m pip install --upgrade "tox<4" tox-gh-actions setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why setuptools
was added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setuptools
is no longer bundled with Python 3.12
setup.cfg
Outdated
@@ -122,7 +125,7 @@ deps = | |||
dj42: Django>=4.2,<5.0 | |||
djmain: https://github.com/django/django/archive/main.tar.gz | |||
msgpack>=0.6.0 | |||
pytest | |||
pytest<7.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this coming from master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, from #690
Seems like we need to update pytest to > 7.0 in order to get the tests working for Python 3.12. My initial statement was a little to harsh. |
I am afraid it is a bit early to work add python3.12, it might fail until redis/redis-py#2979 In the meantime #697 will add support for pytest>=7 |
@WisdomPill We have an issue with async SSL in 3.12. But this should release in the 5.x final. |
thanks for the heads up @chayim! 😉 |
We need to wait for the 5.1 release of redis-py before this can be merged, right? |
Everything seems fine for Python 3.12 and no change are required.